Make major box shadows toggleable with Advanced rendering setting #4712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
hmm, I swear there was a reason we used the shadow, but I can't seem to figure out why now. The border actually looks better and more how it was intended to look... |
Member
|
Since this also disables the main shadow which we definitely want to keep especially in light mode, I moved that to be toggleable with the Advanced rendering setting which removes other blur effects. |
Prospector
approved these changes
Nov 7, 2025
Prospector
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3057
I found a large amount of frame time in webkitgtk is being spent applying blur filter while rendering this box shadow. The 1px wide shadow essentially looks like a border, so visually it looks similar just using a simple border, and has much improved performance on Linux