Adopt scm/repository #8105
Adopt scm/repository #8105
Conversation
package.json
Outdated
| "when": "scmProvider =~ /^git|^remoteHub:github/ && scmProviderRootUri in github:reposNotInReviewMode", | ||
| "group": "navigation" | ||
| }, | ||
| { |
There was a problem hiding this comment.
Do you really want to add it in both places?
There was a problem hiding this comment.
I thought that was best pactice. Anything that is added to the inline menu should also show in the context menu.
There was a problem hiding this comment.
Given that menu items in the inline group can be hidden and then it will move to the ... I would only add it inline
There was a problem hiding this comment.
GHPR has been following this best practice for just about every command (and where it doesn't, it's a mistake). If the best practice has changed, then it should be adopted for all menus in GHPR. For now, I will add it to both and we can discuss if the best practice has changed.
There was a problem hiding this comment.
Ok, I'm seeing that extension tree menus behave differently here. You cannot right click and hide actions in extension trees.
There was a problem hiding this comment.
I'll remove this from the context menu, and we can discuss in standup what should be done about the inline actions in extension tree.
This reverts commit 1b1de9f.
This reverts commit 4b8b8ae.Reapply "Adopt scm/repository (microsoft#8105)" This reverts commit 4b8b8ae.
This reverts commit 4b8b8ae.
No description provided.