-
Notifications
You must be signed in to change notification settings - Fork 2.8k
chore: migrate to jest v30 #35456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
chore: migrate to jest v30 #35456
Conversation
| @@ -1,4 +1,4 @@ | |||
| // Jest Snapshot v1, https://goo.gl/fbAQLP | |||
| // Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
| "name": "Debug current open test", | ||
| "type": "node", | ||
| "request": "launch", | ||
| "program": "${workspaceRoot}/scripts/executors/src/debug-test.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Avatar Converged 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Avatar Converged.badgeMask - RTL.normal.chromium.png | 6 | Changed |
vr-tests-react-components/Drawer 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Drawer.overlay drawer full.chromium.png | 3323 | Changed |
| vr-tests-react-components/Drawer.overlay drawer full - Dark Mode.chromium.png | 942 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 853 | Changed |
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 616 | Changed |
vr-tests-react-components/TagPicker 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled - Dark Mode.disabled input hover.chromium.png | 659 | Changed |
vr-tests-web-components/MenuList 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/MenuList. - RTL.2nd selected.chromium.png | 17 | Changed |
| vr-tests-web-components/MenuList. - RTL.normal.chromium_1.png | 39082 | Changed |
vr-tests/Callout 7 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/Callout.Bottom center.default.chromium.png | 2116 | Changed |
| vr-tests/Callout.Bottom left edge - RTL.default.chromium.png | 2186 | Changed |
| vr-tests/Callout.Bottom right edge.default.chromium.png | 1120 | Changed |
| vr-tests/Callout.Bottom right edge - RTL.default.chromium.png | 1114 | Changed |
| vr-tests/Callout.Right center.default.chromium.png | 2080 | Changed |
| vr-tests/Callout.Left bottom edge.default.chromium.png | 3123 | Changed |
| vr-tests/Callout.Root.default.chromium.png | 2181 | Changed |
vr-tests/react-charting-AreaChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/react-charting-AreaChart.Custom Accessibility.default.chromium.png | 11 | Changed |
vr-tests/react-charting-LineChart 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/react-charting-LineChart.Events.default.chromium.png | 1 | Changed |
| vr-tests/react-charting-LineChart.Events - RTL.default.chromium.png | 15 | Changed |
There were 3 duplicate changes discarded. Check the build logs for more information.
| @@ -1115,7 +1115,7 @@ These are not production-ready components and **should never be used in product* | |||
| }; | |||
| } | |||
|
|
|||
| function getExecSpyCalls(spy: jest.SpyInstance) { | |||
| function getExecSpyCalls(spy: jest.Spied<typeof childProcess.execSync>) { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0209151 to
ae7b442
Compare
| "cwd": "${fileDirname}", | ||
| "stopOnEntry": false, | ||
| "args": ["-i", "--testPathPattern=\\b${fileBasenameNoExtension}", "--watch"], | ||
| "args": ["-i", "--testPathPatterns=\\b${fileBasenameNoExtension}", "--watch"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2ef813a to
65802b1
Compare
65802b1 to
c446113
Compare
Previous Behavior
jest 29
New Behavior
jest v30 announcement
migration guide
ES2015.Symbol.WellKnownas part of their lib. This is necessary because we don't use solution configs besides v9 and jest 30 types contain ES2015++ types. Without this build will failRelated Issue(s)