fix(react-link): fix link brand and inverted appearance #35403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -1,8 +1,8 @@ | |||
| import * as React from 'react'; | |||
| import type { Meta } from '@storybook/react'; | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Charts-DonutChart 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Charts-DonutChart.Dynamic - Dark Mode.default.chromium.png | 12635 | Changed |
| vr-tests-react-components/Charts-DonutChart.Dynamic - RTL.default.chromium.png | 30793 | Changed |
vr-tests-react-components/Link Converged - Rendered as anchor 12 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Link Converged - Rendered as anchor.Brand - Dark Mode.default.chromium.png | 0 | Added |
| vr-tests-react-components/Link Converged - Rendered as anchor.Brand - Dark Mode.focused.chromium.png | 0 | Added |
| vr-tests-react-components/Link Converged - Rendered as anchor.Brand - Dark Mode.hover.chromium.png | 0 | Added |
| vr-tests-react-components/Link Converged - Rendered as anchor.Brand - Dark Mode.pressed.chromium.png | 0 | Added |
| vr-tests-react-components/Link Converged - Rendered as anchor.Brand - High Contrast.default.chromium.png | 0 | Added |
| vr-tests-react-components/Link Converged - Rendered as anchor.Brand - High Contrast.focused.chromium.png | 0 | Added |
| vr-tests-react-components/Link Converged - Rendered as anchor.Brand - High Contrast.hover.chromium.png | 0 | Added |
| vr-tests-react-components/Link Converged - Rendered as anchor.Brand - High Contrast.pressed.chromium.png | 0 | Added |
| vr-tests-react-components/Link Converged - Rendered as anchor.Brand.default.chromium.png | 0 | Added |
| vr-tests-react-components/Link Converged - Rendered as anchor.Brand.focused.chromium.png | 0 | Added |
| vr-tests-react-components/Link Converged - Rendered as anchor.Brand.hover.chromium.png | 0 | Added |
| vr-tests-react-components/Link Converged - Rendered as anchor.Brand.pressed.chromium.png | 0 | Added |
vr-tests-react-components/Link Converged - Rendered as button 12 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Link Converged - Rendered as button.Brand - Dark Mode.default.chromium.png | 0 | Added |
| vr-tests-react-components/Link Converged - Rendered as button.Brand - Dark Mode.focused.chromium.png | 0 | Added |
| vr-tests-react-components/Link Converged - Rendered as button.Brand - Dark Mode.hover.chromium.png | 0 | Added |
| vr-tests-react-components/Link Converged - Rendered as button.Brand - Dark Mode.pressed.chromium.png | 0 | Added |
| vr-tests-react-components/Link Converged - Rendered as button.Brand - High Contrast.default.chromium.png | 0 | Added |
| vr-tests-react-components/Link Converged - Rendered as button.Brand - High Contrast.focused.chromium.png | 0 | Added |
| vr-tests-react-components/Link Converged - Rendered as button.Brand - High Contrast.hover.chromium.png | 0 | Added |
| vr-tests-react-components/Link Converged - Rendered as button.Brand - High Contrast.pressed.chromium.png | 0 | Added |
| vr-tests-react-components/Link Converged - Rendered as button.Brand.default.chromium.png | 0 | Added |
| vr-tests-react-components/Link Converged - Rendered as button.Brand.focused.chromium.png | 0 | Added |
| vr-tests-react-components/Link Converged - Rendered as button.Brand.hover.chromium.png | 0 | Added |
| vr-tests-react-components/Link Converged - Rendered as button.Brand.pressed.chromium.png | 0 | Added |
vr-tests-react-components/Link Converged - Rendered as span 16 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Link Converged - Rendered as span.Inverted - Dark Mode.focused.chromium.png | 498 | Changed |
| vr-tests-react-components/Link Converged - Rendered as span.Inverted - Dark Mode.pressed.chromium.png | 649 | Changed |
| vr-tests-react-components/Link Converged - Rendered as span.Inverted - High Contrast.focused.chromium.png | 639 | Changed |
| vr-tests-react-components/Link Converged - Rendered as span.Inverted - High Contrast.pressed.chromium.png | 795 | Changed |
| vr-tests-react-components/Link Converged - Rendered as span.Brand - Dark Mode.default.chromium.png | 0 | Added |
| vr-tests-react-components/Link Converged - Rendered as span.Brand - Dark Mode.focused.chromium.png | 0 | Added |
| vr-tests-react-components/Link Converged - Rendered as span.Brand - Dark Mode.hover.chromium.png | 0 | Added |
| vr-tests-react-components/Link Converged - Rendered as span.Brand - Dark Mode.pressed.chromium.png | 0 | Added |
| vr-tests-react-components/Link Converged - Rendered as span.Brand - High Contrast.default.chromium.png | 0 | Added |
| vr-tests-react-components/Link Converged - Rendered as span.Brand - High Contrast.focused.chromium.png | 0 | Added |
| vr-tests-react-components/Link Converged - Rendered as span.Brand - High Contrast.hover.chromium.png | 0 | Added |
| vr-tests-react-components/Link Converged - Rendered as span.Brand - High Contrast.pressed.chromium.png | 0 | Added |
| vr-tests-react-components/Link Converged - Rendered as span.Brand.default.chromium.png | 0 | Added |
| vr-tests-react-components/Link Converged - Rendered as span.Brand.focused.chromium.png | 0 | Added |
| vr-tests-react-components/Link Converged - Rendered as span.Brand.hover.chromium.png | 0 | Added |
| vr-tests-react-components/Link Converged - Rendered as span.Brand.pressed.chromium.png | 0 | Added |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 488 | Changed |
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 51 | Changed |
vr-tests-react-components/Toast 6 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Toast.Title Only Inverted - High Contrast.Toast visible.chromium.png | 572 | Changed |
| vr-tests-react-components/Toast.Full Toast Inverted - High Contrast.Toast visible.chromium.png | 1717 | Changed |
| vr-tests-react-components/Toast.Title Only Inverted - Dark Mode.Toast visible.chromium.png | 454 | Changed |
| vr-tests-react-components/Toast.Full Toast Inverted - Dark Mode.Toast visible.chromium.png | 1364 | Changed |
| vr-tests-react-components/Toast.Without Subtitle Inverted - Dark Mode.Toast visible.chromium.png | 1364 | Changed |
| vr-tests-react-components/Toast.Without Subtitle Inverted - High Contrast.Toast visible.chromium.png | 1717 | Changed |
There were 20 duplicate changes discarded. Check the build logs for more information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update improves the existing inverted variant styling for react-link and introduces support for the onBrand variant. We are maintaining current styles to avoid a breaking change. The goal is to bring Figma and code into alignment. Until now, onBrand was available only in Figma, while inverted was implemented only in code.
Figma spec
More context and partners approval
Previous Behavior
Incorrect
invertedstyles, missingonBrandfrom FigmaInverted with dark theme
New Behavior
Related Issue(s)