Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix: adjust chart margin for continuous y-axis tick labels",
"packageName": "@fluentui/react-charting",
"email": "kumarkshitij@microsoft.com",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix: adjust chart margin for continuous y-axis tick labels",
"packageName": "@fluentui/react-charts",
"email": "kumarkshitij@microsoft.com",
"dependentChangeType": "patch"
}
15 changes: 4 additions & 11 deletions packages/charts/react-charting/etc/react-charting.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -416,6 +416,8 @@ export interface ICartesianChartProps {
};
secondaryYScaleType?: AxisScaleType;
showXAxisLablesTooltip?: boolean;
showYAxisLables?: boolean;
showYAxisLablesTooltip?: boolean;
strokeWidth?: number;
styles?: IStyleFunctionOrObject<ICartesianChartStyleProps, ICartesianChartStyles>;
supportNegativeData?: boolean;
Expand Down Expand Up @@ -814,8 +816,6 @@ export interface IGanttChartProps extends ICartesianChartProps {
maxBarHeight?: number;
onRenderCalloutPerDataPoint?: IRenderFunction<IGanttChartDataPoint>;
roundCorners?: boolean;
showYAxisLables?: boolean;
showYAxisLablesTooltip?: boolean;
styles?: IStyleFunctionOrObject<IGanttChartStyleProps, IGanttChartStyles>;
yAxisPadding?: number;
}
Expand Down Expand Up @@ -1008,8 +1008,6 @@ export interface IHeatMapChartProps extends Pick<ICartesianChartProps, Exclude<k
domainValuesForColorScale: number[];
legendProps?: Partial<ILegendsProps>;
rangeValuesForColorScale: string[];
showYAxisLables?: boolean;
showYAxisLablesTooltip?: boolean;
sortOrder?: 'none' | 'alphabetical';
styles?: IStyleFunctionOrObject<IHeatMapChartStyleProps, IHeatMapChartStyles>;
xAxisDateFormatString?: string;
Expand Down Expand Up @@ -1109,8 +1107,6 @@ export interface IHorizontalBarChartWithAxisProps extends ICartesianChartProps {
enableGradient?: boolean;
onRenderCalloutPerDataPoint?: IRenderFunction<IHorizontalBarChartWithAxisDataPoint>;
roundCorners?: boolean;
showYAxisLables?: boolean;
showYAxisLablesTooltip?: boolean;
styles?: IStyleFunctionOrObject<IHorizontalBarChartWithAxisStyleProps, IHorizontalBarChartWithAxisStyles>;
useSingleColor?: boolean;
yAxisPadding?: number;
Expand Down Expand Up @@ -1377,7 +1373,7 @@ export interface IModifiedCartesianChartProps extends ICartesianChartProps {
// Warning: (ae-forgotten-export) The symbol "ChartTypes" needs to be exported by the entry point index.d.ts
Copy link

@github-actions github-actions bot Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual changes to review in the Visual Change Report

vr-tests-react-components/Charts-LineChart 8 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Charts-LineChart.Basic - Dark Mode.default.chromium.png 2354 Changed
vr-tests-react-components/Charts-LineChart.Gaps.default.chromium.png 3846 Changed
vr-tests-react-components/Charts-LineChart.Basic.default.chromium.png 3702 Changed
vr-tests-react-components/Charts-LineChart.Basic - RTL.default.chromium.png 3059 Changed
vr-tests-react-components/Charts-LineChart.Gaps - RTL.default.chromium.png 4718 Changed
vr-tests-react-components/Charts-LineChart.Basic - Dark Mode.hover.chromium.png 2342 Changed
vr-tests-react-components/Charts-LineChart.Basic.hover.chromium.png 3809 Changed
vr-tests-react-components/Charts-LineChart.Gaps - Dark Mode.default.chromium.png 2575 Changed
vr-tests-react-components/Positioning 2 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Positioning.Positioning end.chromium.png 16 Changed
vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png 611 Changed
vr-tests-react-components/Skeleton converged 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Skeleton converged.Opaque Skeleton with rectangle - Dark Mode.default.chromium.png 13 Changed
vr-tests-react-components/TagPicker 2 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/TagPicker.disabled - Dark Mode.chromium.png 659 Changed
vr-tests-react-components/TagPicker.disabled - RTL.disabled input hover.chromium.png 635 Changed
vr-tests/Callout 5 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests/Callout.Bottom center.default.chromium.png 2116 Changed
vr-tests/Callout.Left center.default.chromium.png 2544 Changed
vr-tests/Callout.Bottom left edge - RTL.default.chromium.png 2186 Changed
vr-tests/Callout.No callout width specified.default.chromium.png 2126 Changed
vr-tests/Callout.Right bottom edge.default.chromium.png 3037 Changed
vr-tests/Keytip 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests/Keytip.Root.default.chromium.png 55 Changed
vr-tests/react-charting-AreaChart 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests/react-charting-AreaChart.Custom Accessibility.default.chromium.png 11 Changed
vr-tests/react-charting-GaugeChart 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests/react-charting-GaugeChart.Basic.default.chromium.png 2 Changed
vr-tests/react-charting-LineChart 8 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests/react-charting-LineChart.Basic - RTL.default.chromium.png 2774 Changed
vr-tests/react-charting-LineChart.Basic.default.chromium.png 3644 Changed
vr-tests/react-charting-LineChart.Gaps - RTL.default.chromium.png 4463 Changed
vr-tests/react-charting-LineChart.Basic - Dark Mode.default.chromium.png 2031 Changed
vr-tests/react-charting-LineChart.Basic.hover.chromium.png 4571 Changed
vr-tests/react-charting-LineChart.Basic - Dark Mode.hover.chromium.png 2930 Changed
vr-tests/react-charting-LineChart.Gaps - Dark Mode.default.chromium.png 2141 Changed
vr-tests/react-charting-LineChart.Gaps.default.chromium.png 3694 Changed

There were 2 duplicate changes discarded. Check the build logs for more information.

chartType: ChartTypes;
children(props: IChildProps): React_2.ReactNode;
createStringYAxis: (yAxisParams: IYAxisParams, dataPoints: string[], isRtl: boolean, barWidth: number | undefined, chartType?: ChartTypes) => ScaleBand<string>;
createStringYAxis: (yAxisParams: IYAxisParams, dataPoints: string[], isRtl: boolean, axisData: IAxisData, barWidth: number | undefined, chartType?: ChartTypes) => ScaleBand<string>;
// Warning: (ae-forgotten-export) The symbol "IYAxisParams" needs to be exported by the entry point index.d.ts
// Warning: (ae-forgotten-export) The symbol "IAxisData" needs to be exported by the entry point index.d.ts
createYAxis: (yAxisParams: IYAxisParams, isRtl: boolean, axisData: IAxisData, isIntegralDataset: boolean, useSecondaryYScale?: boolean, supportNegativeData?: boolean, roundedTicks?: boolean, scaleType?: AxisScaleType) => ScaleLinear<number, number, never>;
Expand All @@ -1390,7 +1386,7 @@ export interface IModifiedCartesianChartProps extends ICartesianChartProps {
getAxisData?: any;
getDomainMargins?: (containerWidth: number) => IMargins;
// Warning: (ae-forgotten-export) The symbol "IDomainNRange" needs to be exported by the entry point index.d.ts
getDomainNRangeValues: (points: ILineChartPoints[] | IVerticalBarChartDataPoint[] | IVerticalStackedBarDataPoint[] | IHorizontalBarChartWithAxisDataPoint[] | IGroupedVerticalBarChartData[] | IHeatMapChartDataPoint[] | IGanttChartDataPoint[], margins: IMargins, width: number, chartType: ChartTypes, isRTL: boolean, xAxisType: XAxisTypes, barWidth: number, tickValues: Date[] | number[] | string[] | undefined, shiftX: number) => IDomainNRange;
getDomainNRangeValues: (points: ILineChartPoints[] | IVerticalBarChartDataPoint[] | IVerticalStackedBarDataPoint[] | IHorizontalBarChartWithAxisDataPoint[] | IGroupedVerticalBarChartData[] | IHeatMapChartDataPoint[] | IGanttChartDataPoint[], margins: IMargins, width: number, chartType: ChartTypes, isRTL: boolean, xAxisType: XAxisTypes, barWidth: number, tickValues: Date[] | number[] | string[] | undefined) => IDomainNRange;
getGraphData?: any;
getmargins?: (margins: IMargins) => void;
getMinMaxOfYAxis: (points: ILineChartPoints[] | IHorizontalBarChartWithAxisDataPoint[] | IVerticalBarChartDataPoint[] | IDataPoint[] | IScatterChartPoints[] | IGanttChartDataPoint[], yAxisType: YAxisType | undefined, useSecondaryYScale?: boolean) => {
Expand Down Expand Up @@ -1633,7 +1629,6 @@ export interface IScatterChartProps extends ICartesianChartProps {
data: IChartProps;
getCalloutDescriptionMessage?: (calloutDataProps: ICustomizedCalloutData) => string | undefined;
onRenderCalloutPerDataPoint?: IRenderFunction<ICustomizedCalloutData>;
showYAxisLablesTooltip?: boolean;
styles?: IScatterChartStyles;
}

Expand Down Expand Up @@ -1895,8 +1890,6 @@ export interface IVerticalStackedBarChartProps extends ICartesianChartProps {
onRenderCalloutPerDataPoint?: IRenderFunction<IVSChartDataPoint>;
onRenderCalloutPerStack?: IRenderFunction<IVerticalStackedChartProps>;
roundCorners?: boolean;
showYAxisLables?: boolean;
showYAxisLablesTooltip?: boolean;
styles?: IStyleFunctionOrObject<IVerticalStackedBarChartStyleProps, IVerticalStackedBarChartStyles>;
xAxisInnerPadding?: number;
xAxisOuterPadding?: number;
Expand Down
Loading