-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(charts): adjust chart margin for continuous y-axis tick labels #35376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
krkshitij
wants to merge
12
commits into
microsoft:master
Choose a base branch
from
krkshitij:bug-13389
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,750
−1,811
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
892472a
adjust chart margin for continuous y-axis tick labels
krkshitij 55eb968
fix tests
krkshitij 7f06382
update api
krkshitij 3a77443
port changes to v9
krkshitij 7824267
add change files
krkshitij f7a5417
add showYAxisLabels prop to all cartesian charts + include startFromX…
krkshitij 168d238
port changes to v9
krkshitij 5236f57
fix type errors
krkshitij dcb62be
fix bug
krkshitij 40b87b5
fix bug
krkshitij c359ee4
Merge branch 'master' of https://github.com/microsoft/fluentui into b…
krkshitij 611fa01
refactor
krkshitij File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
change/@fluentui-react-charting-680fcbd4-d208-4ef2-92a0-3734d64a59cd.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "patch", | ||
| "comment": "fix: adjust chart margin for continuous y-axis tick labels", | ||
| "packageName": "@fluentui/react-charting", | ||
| "email": "kumarkshitij@microsoft.com", | ||
| "dependentChangeType": "patch" | ||
| } |
7 changes: 7 additions & 0 deletions
7
change/@fluentui-react-charts-d5577841-97c9-4fde-ac7e-31db789e05a9.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "patch", | ||
| "comment": "fix: adjust chart margin for continuous y-axis tick labels", | ||
| "packageName": "@fluentui/react-charts", | ||
| "email": "kumarkshitij@microsoft.com", | ||
| "dependentChangeType": "patch" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Charts-LineChart 8 screenshots
vr-tests-react-components/Positioning 2 screenshots
vr-tests-react-components/Skeleton converged 1 screenshots
vr-tests-react-components/TagPicker 2 screenshots
vr-tests/Callout 5 screenshots
vr-tests/Keytip 1 screenshots
vr-tests/react-charting-AreaChart 1 screenshots
vr-tests/react-charting-GaugeChart 1 screenshots
vr-tests/react-charting-LineChart 8 screenshots
There were 2 duplicate changes discarded. Check the build logs for more information.