Remove StyleMedia #2199
Open
Remove StyleMedia #2199
+0
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
|
This is removing StyleMedia not StylePropertyMap, please change the title |
|
React v15 is still using this, it seems. Probably not worth removing? |
|
Yeah, we should try adding it to DT and maybe revisit this later |
|
Can you try to test this since the definitely typed PR was merged? @jakebailey |
|
microsoft/TypeScript#62640 is happy on DT, but causes very odd test failures elsewhere that I need to investigate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can you test this @jakebailey ?
Sorry for the late PR, I was busy