[FIRRTL] Add domain verification to instance ops and domain support to instance choice ops #9074
+103
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwy7
force-pushed
the
fix-domain-verifiers
branch
from
2135596 to
88d4508
Compare
dtzSiFive
approved these changes
Oct 9, 2025
There was a problem hiding this comment.
Verifier and test changes LGTM.
The builder changes -- they seem part of a related/necessary (but not in PR scope per title?) change: adding Domain support for InstanceChoiceOp's.
Please either mention this change in the title/commit or split out 👍.
(and consider positive test for instance choice op domain support?)
rwy7
force-pushed
the
fix-domain-verifiers
branch
2 times, most recently
from
ad56f83 to
0802c31
Compare
rwy7
force-pushed
the
fix-domain-verifiers
branch
from
0802c31 to
a086f90
Compare
rwy7
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes related to domains:
The subroutine which verifies instance ops against their target module is shared by the instance choice op, so adding domain verification to this subroutine was made easier by also adding support for domains to instance choice ops.