Skip to content

Conversation

@marosset
Copy link
Contributor

@marosset marosset commented Nov 5, 2025

… images produced from image-builder before promoting them

Signed-off-by: Mark Rossett <marosset@microsoft.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 5, 2025
@marosset
Copy link
Contributor Author

marosset commented Nov 5, 2025

/hold
I am going to add a prow job to target the staging gallery and then trigger that on this PR as well

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2025
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marosset, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marosset
Copy link
Contributor Author

marosset commented Nov 5, 2025

/test ls

@k8s-ci-robot
Copy link
Contributor

@marosset: The specified target(s) for /test were not found.
The following commands are available to trigger optional jobs:

/test pull-e2e-capz-validate-pr-templates
/test pull-e2e-capz-windows-2022-extension
/test pull-e2e-capz-windows-2022-extension-community-eks
/test pull-e2e-capz-windows-2022-extension-community-gke
/test pull-e2e-capz-windows-2022-extension-gmsa
/test pull-e2e-capz-windows-2022-staging-gallery
/test pull-e2e-capz-windows-2025-extension
/test pull-e2e-capz-windows-2025-staging-gallery
/test pull-e2e-run-capz-sh-windows-2022-hyperv
/test pull-kubernetes-e2enode-windows
/test pull-kubernetes-unit-windows

Use /test all to run the following jobs that were automatically triggered:

pull-e2e-capz-windows-2022-extension
pull-e2e-capz-windows-2025-extension

In response to this:

/test ls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@marosset
Copy link
Contributor Author

marosset commented Nov 5, 2025

/test pull-e2e-capz-windows-2022-staging-gallery
/test pull-e2e-capz-windows-2025-staging-gallery

@marosset
Copy link
Contributor Author

marosset commented Nov 5, 2025

/test pull-e2e-capz-windows-2022-staging-gallery
/test pull-e2e-capz-windows-2025-staging-gallery

New gallery images have been published to the staging gallery (previously there were none)

@marosset
Copy link
Contributor Author

marosset commented Nov 6, 2025

I think we need to scope the *-stagign-gallery jobs to a single region.
I'm seeing

	  "error": {
	    "code": "GalleryImageNotFound",
	    "message": "\"The gallery image /subscriptions/46678f10-4bbb-447e-98e8-d2829589f2d8/resourceGroups/cluster-api-gallery/providers/Microsoft.Compute/galleries/staging_gallery/images/capi-win-2022-containerd/versions/latest is not available in SwitzerlandNorth region. Please contact image owner to replicate to this region, or change your requested region.\"",
	    "target": "imageReference"
	  }

@marosset
Copy link
Contributor Author

marosset commented Nov 6, 2025

/test pull-e2e-capz-windows-2022-staging-gallery
/test pull-e2e-capz-windows-2025-staging-gallery

@marosset
Copy link
Contributor Author

marosset commented Nov 6, 2025

/test pull-e2e-capz-windows-2022-staging-gallery
/test pull-e2e-capz-windows-2025-staging-gallery

@marosset
Copy link
Contributor Author

marosset commented Nov 6, 2025

/hold cancel
the jobs targeting windows images from the staging azure compute gallery are passing!

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 6, 2025
@marosset marosset added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 6, 2025
@k8s-ci-robot k8s-ci-robot merged commit ddce134 into kubernetes-sigs:master Nov 6, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants