Specify fileSystemId from K8 ConfigMap/Secret

[aliyajo]

Is this a bug fix or adding new feature?

Adds a feature via #1615

What is this PR about? / Why do we need it?

Adds support for dynamically resolving filesystemId from K8 ConfigMaps and Secrets instead of having to manually copy the fileSystem Id.

Can reference ConfigMaps or Secrets containing FileSystemIDs, which the CSI driver will read automatically during provisioning.

New StorageClass parameters

• fileSystemIdConfigRef: Reference to a ConfigMap
• fileSystemIdSecretRef: Reference to a Secret

Reference Format: namespace/name/key

Example:

# ConfigMap created
apiVersion: v1
kind: ConfigMap
metadata:
  name: efs-config
  namespace: kube-system
data:
  fileSystemId: fs-02604354c13d0316d
---
# StorageClass references the ConfigMap
kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
  name: efs-sc
provisioner: efs.csi.aws.com
parameters:
  provisioningMode: efs-ap
  fileSystemIdConfigRef: "kube-system/efs-config/fileSystemId"
  directoryPerms: "700"

Features:

• Opt-in security: RBAC only granted when controller.fileSystemIdRefs.enabled=true (default:false)
• Support for both ConfigMaps and Secrets

What testing is done?

• Unit testing
• Integration Tests

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: aliyajo / name: Aliya Jordan (2de7378, 512c188, dfde5e9, e1365e6)

[k8s-ci-robot]

Welcome @aliyajo!

It looks like this is your first PR to kubernetes-sigs/aws-efs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-efs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @aliyajo. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[DavidXU12345]

lgtm, just leave some nit comments, up to you whether to do it in this PR or not

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliyajo, DavidXU12345

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [DavidXU12345]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[DavidXU12345]

/ok-to-test

[DavidXU12345]

/retest