-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix: update broken Contribute links and redirects #6484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update broken Contribute links and redirects #6484
Conversation
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Welcome @codeEvolveZenith345! It looks like this is your first PR to knative/docs 🎉 |
…butor guide. Prevents 404 errors and improves developer documentation and onboarding experience Signed-off-by: codeEvolveZenith345 <suntiwari3495@gmail.com>
a702edd to
69c5309
Compare
evankanderson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the redirects should stay same-site, rather than hard-coding the hostname part of the URL -- this allows us to check out the behavior on previews, like
https://deploy-preview-6484--knative.netlify.app/docs/contributing/about
(Oddly, this redirect still works -- so it may be that something else is overwriting the hostname in the redirect map.)
|
/assign |
Signed-off-by: codeEvolveZenith345 <suntiwari3495@gmail.com>
evankanderson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making the the "use host-relative paths" suggestion as suggested edits.
Co-authored-by: Evan Anderson <evan.k.anderson@gmail.com>
Co-authored-by: Evan Anderson <evan.k.anderson@gmail.com>
|
hey @evankanderson Thank you. |
evankanderson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: codeEvolveZenith345, evankanderson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR updates all broken "Contribute" links and redirection rules throughout the documentation and config files to point to the official Knative contributor guide. Prevents 404 errors and improves developer onboarding.
Proposed Changes
/contributing/redirects and documentation links to use https://knative.dev/community/contributing/Fixes #6483