Skip to content

Conversation

@iRaindrop
Copy link
Contributor

@iRaindrop iRaindrop commented Oct 17, 2025

Need topic to install the Kourier plugin. Source: https://github.com/knative-extensions/net-kourier

Proposed Changes

  • Create Installing Kourier to include in the Plugin section for Installing Knative.

@knative-prow knative-prow bot requested review from dsimansk and pierDipi October 17, 2025 06:54
@knative-prow
Copy link

knative-prow bot commented Oct 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: iRaindrop
Once this PR has been reviewed and has the lgtm label, please assign zainabhusain227 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 17, 2025
@iRaindrop iRaindrop marked this pull request as draft October 17, 2025 06:55
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 17, 2025
@netlify
Copy link

netlify bot commented Oct 17, 2025

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e5956c0
🔍 Latest deploy log https://app.netlify.com/projects/knative/deploys/68f5e19482d1860008d06769
😎 Deploy Preview https://deploy-preview-6456--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@iRaindrop iRaindrop changed the title Add Installing-Kourier to Knative installation documentation Add Installing Kourier to Knative installation documentation Oct 17, 2025
@iRaindrop iRaindrop changed the title Add Installing Kourier to Knative installation documentation Add Installing Kourier to docs Oct 17, 2025
@iRaindrop iRaindrop marked this pull request as ready for review October 20, 2025 07:20
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 20, 2025
Copy link
Member

@dprotaso dprotaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious - we cover this stuff here already given it's related to serving - are these pages meant to be duplicated or are we cleaning out the sections?

https://knative.dev/docs/install/yaml-install/serving/install-serving-with-yaml/#install-a-networking-layer

Comment on lines +26 to +31
1. Install Knative Serving if not already installed:

``` bash
kubectl apply -f https://github.com/knative/serving/releases/latest/download/serving-crds.yaml
kubectl apply -f https://github.com/knative/serving/releases/latest/download/serving-core.yaml
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to Serving installation page?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dave - yes we should link to installing a network layer for both kourier and Contour. Will consult with Evan.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'd link this to ./yaml-install/serving/install-serving-with-yaml.md, rather than including inline instructions.

Also, we say that having Knative Serving installed is a pre-requisite, so it's weird to also have install instructions here.

I don't recall what the equivalent Operator version is, so you might want to leave a <!-- TODO: add operator-equivalent instructions --> somewhere in this file.

1. Install Kourier:

```bash
kubectl apply -f https://github.com/knative/net-kourier/releases/latest/download/kourier.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

latest should be a release version - we have a macro somewhere for that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
kubectl apply -f https://github.com/knative/net-kourier/releases/latest/download/kourier.yaml
kubectl apply -f {{ artifact(repo="net-kourier",org="knative-extensions",file="kourier.yaml" }}

(Taken from the install-serving-with-yaml.md instructions.)

Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for collecting this documentation! A few comments, but it's nice to have the documentation gathered in one place.

It looks like most of the configuration information was surfaced from outside the existing docs tree, so thanks for digging that up!

Comment on lines +26 to +31
1. Install Knative Serving if not already installed:

``` bash
kubectl apply -f https://github.com/knative/serving/releases/latest/download/serving-crds.yaml
kubectl apply -f https://github.com/knative/serving/releases/latest/download/serving-core.yaml
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'd link this to ./yaml-install/serving/install-serving-with-yaml.md, rather than including inline instructions.

Also, we say that having Knative Serving installed is a pre-requisite, so it's weird to also have install instructions here.

I don't recall what the equivalent Operator version is, so you might want to leave a <!-- TODO: add operator-equivalent instructions --> somewhere in this file.

1. Install Kourier:

```bash
kubectl apply -f https://github.com/knative/net-kourier/releases/latest/download/kourier.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
kubectl apply -f https://github.com/knative/net-kourier/releases/latest/download/kourier.yaml
kubectl apply -f {{ artifact(repo="net-kourier",org="knative-extensions",file="kourier.yaml" }}

(Taken from the install-serving-with-yaml.md instructions.)

Comment on lines +48 to +55
1. Optional - Set your desired domain (replace `127.0.0.1.nip.io` to your preferred domain):

```bash
kubectl patch configmap/config-domain \
-n knative-serving \
--type merge \
-p '{"data":{"127.0.0.1.nip.io":""}}'
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not Kourier-specific, though we should describe how to find Kourier's external IP address (from install-serving-with-yaml.md):

kubectl --namespace kourier-system get service kourier

I would put this in a separate section (since we have its own page). Something like "DNS configuration"

Comment on lines +59 to +74
```bash
cat <<-EOF | kubectl apply -f -
apiVersion: serving.knative.dev/v1
kind: Service
metadata:
name: helloworld-go
spec:
template:
spec:
containers:
- image: gcr.io/knative-samples/helloworld-go
env:
- name: TARGET
value: Go Sample v1
EOF
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, I would either omit this, or put it in a "verification" section, since it's not required for the installation.

Comment on lines +76 to +82
1. Optional - For testing purposes, you can use port-forwarding to make requests to Kourier from your machine:

```bash
kubectl port-forward --namespace kourier-system $(kubectl get pod -n kourier-system -l "app=3scale-kourier-gateway" --output=jsonpath="{.items[0].metadata.name}") 8080:8080 19000:9000 8443:8443

curl -v -H "Host: helloworld-go.default.127.0.0.1.nip.io" http://localhost:8080
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably wouldn't include this at all. If we do want to include these commands, I'd put them under verification / troubleshooting, with the detail that these commands can help take external DNS resolution and cluster loadbalancing out of the picture if you think you're having trouble with those components. But I'd expect most administrators to be able to check those components themselves, since we're assuming that they have cluster administration experience, and a cluster with malfunctioning load balancing or DNS is probably going to have problems beyond Knative Serving.


By default, the deployment of the Kourier components is split between two different namespaces:

- `knative-serving` - Namespace where Kourier control is deployed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `knative-serving` - Namespace where Kourier control is deployed.
- `knative-serving` - Namespace where Kourier controlle is deployed.

- External Authorization support.
- Proxy Protocol (AN EXPERIMENTAL / ALPHA FEATURE)

## Setup TLS certificate
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put this and the remaining topics under a "Configuration" header, and move e.g. h2 elements to h3, and h3 to h4.

@evankanderson
Copy link
Member

/assign

@dprotaso
Copy link
Member

/assign @dsimansk

As the resident Kourier expert

@iRaindrop iRaindrop marked this pull request as draft October 24, 2025 18:52
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 24, 2025
@iRaindrop iRaindrop changed the title Add Installing Kourier to docs Plugin: Kourier Oct 25, 2025
@iRaindrop
Copy link
Contributor Author

This content will now be under Configuring Knative->Networking Options->Plugin: Kourier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants