Fix for replace string in example function #710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm on latest Chrome, and the line `return "#" + myid.replace( /(:|\.|\[|\]|,)/g, "\\$1" )` results in only a single backslash being inserted before each match, as opposed to double backslash, eg `hello:world` > `hello\:world` Changing to `return "#" + myid.replace( /(:|\.|\[|\]|,)/g, "\\\\$1" )` fixes this.
|
Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA). 📝 Please visit http://contribute.jquery.org/CLA/ to sign. After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know. If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm on latest Chrome, and the line
return "#" + myid.replace( /(:|\.|\[|\]|,)/g, "\\$1" )results in only a single backslash being inserted before each match, as opposed to double backslash,eg
hello:world>hello\:worldChanging to
return "#" + myid.replace( /(:|\.|\[|\]|,)/g, "\\\\$1" )fixes this.