Skip to content

Fix jenkins-40998 #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix jenkins-40998 #35

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c862178
Fix jenkins-40998
Jan 11, 2017
4cdc78c
Fix to use get instead of is.
Jan 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/main/java/org/jenkinsci/plugins/bitbucket/BitbucketBuildStatusNotifierStep.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,12 +83,21 @@ public String getCredentialsId() {
private String buildState;
public String getBuildState() { return this.buildState; }


private boolean overrideLatestBuild=false;
public boolean getOverrideLatestBuild() {return this.overrideLatestBuild;}

@DataBoundSetter
public void setOverrideLatestBuild(boolean overrideLatestBuild) {
this.overrideLatestBuild = overrideLatestBuild;
}

@DataBoundConstructor
public BitbucketBuildStatusNotifierStep(final String buildState) {
this.credentialsId = credentialsId;
this.buildState = buildState;
}

@Override
public DescriptorImpl getDescriptor() {
return Jenkins.getInstance().getDescriptorByType(DescriptorImpl.class);
Expand Down Expand Up @@ -186,7 +195,7 @@ public Void run() throws Exception {
BitbucketBuildStatus buildStatus = new BitbucketBuildStatus(buildState, buildKey, buildUrl, buildName,
buildDescription);

BitbucketBuildStatusHelper.notifyBuildStatus(step.getCredentials(build), false, build, taskListener, buildStatus);
BitbucketBuildStatusHelper.notifyBuildStatus(step.getCredentials(build), step.getOverrideLatestBuild(), build, taskListener, buildStatus);

if(buildState.equals(BitbucketBuildStatus.FAILED)) {
throw new Exception(buildDescription);
Expand Down