Fix http linking and enable http test #2353
Conversation
Fix compilation issue with printf and stringview. Printf has to know the length as stringview may not be null-terminated.
- Use latest http-parser from nixpkgs as it now supports static builds - Include libhttp-parser.a in IncludeOS library - Enable http test (which now works again)
MagnusS
changed the title
|
🌈 All tests are passing 🌈 except for the known flaky DNS test |
|
|
||
| CHECKSERT(!err, "No error"); | ||
| printf("Received body: %s\n", res->body()); | ||
| printf("Received body: %.*s\n", static_cast<int>(res->body().length()), res->body().data()); |
There was a problem hiding this comment.
Not using the opportunity to replace printf-specifiers with {}?
There was a problem hiding this comment.
What would that look like?
There was a problem hiding this comment.
For this specific case, I see that res->body() returns util::sview, an alias for std::string_view: a type which is aware of its own size.
In C++23, we'd be able to std::println("{}", res->body());. Super convenient.
In C++20, you can either
std::cout << std::body() << std::endl;
// or if you want to use printf
auto s = std::format("{}", res->body());
printf("%s\n", s.cstr());It's worth noting that if res->body() wasn't a string_view alias, but something else like http::ResponseBody that wasn't a direct subtype of std::string, we'd have to implement (C++23):
namespace http {
inline std::string format_as(const http::ResponseBody& body) {
return body.toString();
}
}For C++20, this requires building a template for std::formatter<ResponseBody, char> with parse() and format() which I personally would rather avoid as it's a bunch of boilerplate. Happily C++23 makes it rather easy.
There was a problem hiding this comment.
Also, for completeness sake, in case you actually need to specify the length:
size_t len = body.length();
char *s = body.data(); // this loses the size() knowledge
std::cout << std::format("{:{}}\n", s, len);
| self.libfmt | ||
| self.botan2 | ||
| self.http-parser | ||
| prev.pkgsStatic.http-parser |
| "${INTEGRATION_TESTS}/net/tcp" | ||
| "${INTEGRATION_TESTS}/net/udp" | ||
| "${INTEGRATION_TESTS}/net/dns" # except this one which times out instead | ||
| "${INTEGRATION_TESTS}/net/http" |
5 participants
length as stringview may not be null-terminated.