-
Notifications
You must be signed in to change notification settings - Fork 7
add ground temperature 1m as option to weather data #1351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Changes from 51 commits
6bb6984
0342ae2
920be80
e259bee
1b8dd09
6a77ffc
d46b0d1
9f767ed
b015b66
8e33409
b0d87d9
0399aa3
813cdbe
88191d1
47ac942
41302fe
3c153a3
83b3736
13f27ee
55a7c15
cde88f0
f0698b4
1d9ff09
4ec2c68
f939e57
55bb4e1
71ab33a
224aa30
6039cc2
46fb11f
082451a
3a0e1e9
57640e2
7f11669
1c5c4ba
3be844f
3f04286
c8f0d18
c067c0b
64c0172
d691a2c
e80cb33
42e8599
ae9da09
481ab12
5efc4d2
41d031e
a1967ea
aa481ca
ac127ec
9d7215c
2b6ed95
fe531ab
47455fe
6338599
b4ace56
2da8ced
f85cf9b
9a6840c
da1a8cf
c5d924d
2aba46d
857989d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| /* | ||
| * © 2025. TU Dortmund University, | ||
| * Institute of Energy Systems, Energy Efficiency and Energy Economics, | ||
| * Research group Distribution grid planning and operation | ||
| */ | ||
| package edu.ie3.datamodel.models.value; | ||
|
|
||
| import javax.measure.quantity.Temperature; | ||
| import tech.units.indriya.ComparableQuantity; | ||
|
|
||
| /** | ||
| * Describes a ground temperature value. This class extends {@link TemperatureValue} to represent | ||
| * temperature at a specific depth in the ground. | ||
| */ | ||
| public class GroundTemperatureValue extends TemperatureValue { | ||
|
|
||
| /** | ||
| * Constructs a new GroundTemperatureValue. | ||
| * | ||
| * @param temperature The temperature quantity (typically in K) | ||
| */ | ||
| public GroundTemperatureValue(ComparableQuantity<Temperature> temperature) { | ||
| super(temperature); | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return "GroundTemperatureValue{" + "temperature=" + getTemperature().orElse(null) + '}'; | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,7 +28,9 @@ class CosmoTimeBasedWeatherValueFactoryTest extends Specification { | |
| "directIrradiance" : "286.872985839844", | ||
| "temperature" : "", | ||
| "windDirection" : "0", | ||
| "windVelocity" : "1.66103506088257" | ||
| "windVelocity" : "1.66103506088257", | ||
| "groundTemperatureLevel1" : "", | ||
| "groundTemperatureLevel2" : "" | ||
| ] | ||
|
|
||
| def data = new TimeBasedWeatherValueData(parameter, coordinate) | ||
|
|
@@ -39,7 +41,9 @@ class CosmoTimeBasedWeatherValueFactoryTest extends Specification { | |
| Quantities.getQuantity(282.671997070312d, StandardUnits.SOLAR_IRRADIANCE), | ||
| null, | ||
| Quantities.getQuantity(0d, StandardUnits.WIND_DIRECTION), | ||
| Quantities.getQuantity(1.66103506088257d, StandardUnits.WIND_VELOCITY))) | ||
| Quantities.getQuantity(1.66103506088257d, StandardUnits.WIND_VELOCITY), | ||
| Optional.empty(), | ||
| Optional.empty())) | ||
|
|
||
| when: | ||
| def model = factory.buildModel(data) | ||
|
|
@@ -61,7 +65,9 @@ class CosmoTimeBasedWeatherValueFactoryTest extends Specification { | |
| "directIrradiance" : "286.872985839844", | ||
| "temperature" : "278.019012451172", | ||
| "windDirection" : "0", | ||
| "windVelocity" : "1.66103506088257" | ||
| "windVelocity" : "1.66103506088257", | ||
| "groundTemperatureLevel1" : "", | ||
| "groundTemperatureLevel2" : "" | ||
| ] | ||
|
Comment on lines
+68
to
71
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. format |
||
|
|
||
| def data = new TimeBasedWeatherValueData(parameter, coordinate) | ||
|
|
@@ -72,7 +78,9 @@ class CosmoTimeBasedWeatherValueFactoryTest extends Specification { | |
| Quantities.getQuantity(282.671997070312d, StandardUnits.SOLAR_IRRADIANCE), | ||
| Quantities.getQuantity(278.019012451172d, StandardUnits.TEMPERATURE), | ||
| Quantities.getQuantity(0d, StandardUnits.WIND_DIRECTION), | ||
| Quantities.getQuantity(1.66103506088257d, StandardUnits.WIND_VELOCITY))) | ||
| Quantities.getQuantity(1.66103506088257d, StandardUnits.WIND_VELOCITY), | ||
| Optional.of(Quantities.getQuantity(278.019012451172d, StandardUnits.TEMPERATURE)), | ||
| Optional.of(Quantities.getQuantity(278.019012451172d, StandardUnits.TEMPERATURE)))) | ||
|
Comment on lines
+82
to
+83
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is not correct. see #1470
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please have a look on my proposal in #1470 and adapt the check of the expected values the same way (split into |
||
|
|
||
| when: | ||
| def model = factory.buildModel(data) | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.