Skip to content

Conversation

@brandon-pereira
Copy link
Member

Add title tags to most important pages, add a fallback title page so any other pages will have something basic.

Fixes HDX-2706

@changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2025

🦋 Changeset detected

Latest commit: ffe435e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 31, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview Comment Nov 5, 2025 7:46pm

@claude
Copy link

claude bot commented Oct 31, 2025

✅ No critical issues found.

Minor observation (non-blocking):

  • The fallback title in _app.tsx provides good coverage for pages without explicit titles
  • Page-specific titles follow consistent pattern: [Page Name] - HyperDX
  • Implementation correctly uses Next.js Head component

This is a clean improvement to SEO and browser tab UX.

@brandon-pereira brandon-pereira requested review from a team and knudtty and removed request for a team October 31, 2025 22:13
@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2025

E2E Test Results

All tests passed • 39 passed • 3 skipped • 304s

Status Count
✅ Passed 39
❌ Failed 0
⚠️ Flaky 0
⏭️ Skipped 3

View full report →

@kodiakhq kodiakhq bot merged commit 2faa15a into main Nov 5, 2025
7 of 9 checks passed
@kodiakhq kodiakhq bot deleted the brandon/add-page-titles branch November 5, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants