-
Notifications
You must be signed in to change notification settings - Fork 844
Pass through additional arguments from HfApi download utils
#3531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass through additional arguments from HfApi download utils
#3531
Conversation
Wauplin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
c3749f1 to
7d6d3cb
Compare
HfApi.hf_hub_downloadHfApi download utils
Sure, done -- I've also passed through |
Wauplin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for fixing all of these small details @schmrlng ! Much appreciated 🤗
|
failing test is unrelated so we're good to merge :) |
Co-authored-by: célina <hanouticelina@gmail.com> Co-authored-by: Lucain <lucain@huggingface.co>
This PR
dry_runargument (bug) and also adds thetqdm_classargument fromHfApi.hf_hub_download->hf_hub_download.dry_runargument fromHfApi.snapshot_download->snapshot_downloadand also passesheaders.