feat: adds factory for PendingTransactionStorage creation #4573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
quiet-node
approved these changes
Nov 4, 2025
Contributor
quiet-node
left a comment
quiet-node
left a comment
There was a problem hiding this comment.
LGTM. Should we also create tickets to leverage this same logic for CacheService and rateLimitterService and maybe other services so they can be consistent?
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #4573 +/- ##
==========================================
- Coverage 95.52% 95.49% -0.03%
==========================================
Files 127 128 +1
Lines 20493 20516 +23
Branches 1760 1755 -5
==========================================
+ Hits 19576 19592 +16
- Misses 898 905 +7
Partials 19 19
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a factory method for
PendingTransactionStoragecreation. The storage selection logic used to live in Relay. Relay shouldn't know about storage implementation details. By adding a factory method, this issue is resolvedRelated issue(s)
Fixes #4502
Testing Guide
Changes from original design (optional)
N/A
Additional work needed (optional)
N/A