Skip to content

Editorial: Fix cases in validation where technically a crash could occur due to non-existent definitions #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Editorial: Fix cases in validation where technically a crash could occur due to non-existent definitions #1180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions spec/Section 5 -- Validation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1144,6 +1144,7 @@ DetectFragmentCycles(fragmentDefinition, visited):
- {visited} must not contain {spread}.
- Let {nextVisited} be the set including {spread} and members of {visited}.
- Let {nextFragmentDefinition} be the target of {spread}.
- If {nextFragmentDefinition} can't be found, return.
- {DetectFragmentCycles(nextFragmentDefinition, nextVisited)}.

**Explanatory Text**
Expand Down Expand Up @@ -1995,6 +1996,7 @@ variable.
- Let {variableName} be the name of {variableUsage}.
- Let {variableDefinition} be the {VariableDefinition} named {variableName}
defined within {operation}.
- If no {variableDefinition} can be found, return.
Copy link
Contributor

@martinbonnin martinbonnin Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be caught before by 5.8.3 All Variable Uses Defined?

Copy link
Member

@benjie benjie Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The validation rules don't run in a specific order, they run in parallel / independently. So yes to "is it caught by All Variable Uses Defined?" and no to "before".

Copy link
Contributor

@martinbonnin martinbonnin Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. As an implementer, more guidance on the order would be welcome but definitely out of scope for this PR.

- {IsVariableUsageAllowed(variableDefinition, variableUsage)} must be
{true}.

Expand Down