Skip to content

Fix relativlization bug #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix relativlization bug #792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion common/utils/src/main/java/org/graalvm/buildtools/utils/NativeImageUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,11 @@ public static List<String> convertToArgsFile(List<String> cliArgs, Path outputDi

Path resultingPath = tmpFile.toPath().toAbsolutePath();
if (projectDir != null) { // We know where the project dir is, so want to use relative paths
resultingPath = projectDir.toAbsolutePath().relativize(resultingPath);
Path absProjectDir = projectDir.toAbsolutePath();
// Only relativize if both paths are on the same file system (same drive on Windows)
if (resultingPath.getRoot() != null && resultingPath.getRoot().equals(absProjectDir.getRoot())) {
resultingPath = absProjectDir.relativize(resultingPath);
}
}
return Collections.singletonList("@" + resultingPath);
} catch (IOException e) {
Expand Down
8 changes: 8 additions & 0 deletions docs/src/docs/asciidoc/changelog.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
[[changelog]]
== Changelog

== Release 0.11.3

- Fixed use of argument file when the temporary directory is not on the same drive as the project

== Release 0.11.2

- Fixed missing JUnit types in build time initialization

== Release 0.11.1

- Fix `NoClassDefFoundError` when JUnit feature is missing some dependency
Expand Down
Loading