Skip to content

Conversation

@vjovanov
Copy link
Member

No description provided.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 27, 2025
@vjovanov vjovanov force-pushed the vj/project-documentation-and-testing branch 2 times, most recently from 892bbfb to f2fd551 Compare October 31, 2025 12:53
@vjovanov vjovanov requested a review from melix October 31, 2025 12:54
def matrixDefault = [
"java-version": [ "17" ],
"os": [ "ubuntu-22.04", "windows-latest" ]
"os": [ "ubuntu-22.04", "windows-latest", "macos-latest" ]
Copy link
Member Author

@vjovanov vjovanov Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added macos as I don't see how we can ship without testing that.

melix
melix previously approved these changes Nov 7, 2025
build.gradle.kts Outdated
*/

plugins {
// Aggregates build configurations for all project modules. Required for multi-module builds and reporting.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a redundant comment. AI generated?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant when you know what it does. I wrote it so newcomers can get around better.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this one.

@vjovanov vjovanov force-pushed the vj/project-documentation-and-testing branch from f2fd551 to d9440cd Compare November 19, 2025 13:06
@vjovanov
Copy link
Member Author

@melix can we merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants