-
Notifications
You must be signed in to change notification settings - Fork 80
Enhance Project Documentation and Testing #791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
892bbfb to
f2fd551
Compare
| def matrixDefault = [ | ||
| "java-version": [ "17" ], | ||
| "os": [ "ubuntu-22.04", "windows-latest" ] | ||
| "os": [ "ubuntu-22.04", "windows-latest", "macos-latest" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added macos as I don't see how we can ship without testing that.
build.gradle.kts
Outdated
| */ | ||
|
|
||
| plugins { | ||
| // Aggregates build configurations for all project modules. Required for multi-module builds and reporting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a redundant comment. AI generated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redundant when you know what it does. I wrote it so newcomers can get around better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this one.
f2fd551 to
d9440cd
Compare
|
@melix can we merge this? |
No description provided.