pkg/coverage: adopt new coverage interface for kcov #12257
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the kcov implementation to use the new Go coverage interface provided by the `internal/coverage` package. The previous implementation relied on `coverdata.Blocks`, which is part of the older coverage tooling. The new implementation uses `runtime/coverage.WriteCounters` to get the raw coverage data and then decodes it using `decodecounter.NewDecoder`. This approach is aligned with the modern Go coverage infrastructure. This change requires a patched Go compiler that allows importing internal packages. This is a temporary measure until the golang team provides a public API. More details can be found here: golang/go#51430 FUTURE_COPYBARA_INTEGRATE_REVIEW=#12256 from avagin:kcov-v2-main 33081ed PiperOrigin-RevId: 825669734
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg/coverage: adopt new coverage interface for kcov
This change updates the kcov implementation to use the new Go coverage interface provided by the
internal/coveragepackage. The previous implementation relied oncoverdata.Blocks, which is part of the older coverage tooling.The new implementation uses
runtime/coverage.WriteCountersto get the raw coverage data and then decodes it usingdecodecounter.NewDecoder. This approach is aligned with the modern Go coverage infrastructure.This change requires a patched Go compiler that allows importing internal packages. This is a temporary measure until the golang team provides a public API.
More details can be found here: golang/go#51430
FUTURE_COPYBARA_INTEGRATE_REVIEW=#12256 from avagin:kcov-v2-main 33081ed