Add test coverage for actix-web, poem, and http-types cookie secure attribute #20749
+3,152
−332
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands CWE-614 test coverage to include three additional Rust web frameworks that handle HTTP cookies.
Changes
Added dependencies to
options.yml:actix-web = { version = "4", features = ["cookies"] }poem = { version = "3", features = ["cookie"] }http-types = { version = "2", features = ["cookies"] }Added test functions in
main.rs:test_actix_web()- Usesactix_web::cookie::Cookie::new()+set_secure()test_poem()- Usespoem::web::cookie::Cookie::new_with_str()+set_secure()test_http_types()- Useshttp_types::Cookie::new()+set_secure()Each test validates three cases: secure explicitly false, secure explicitly true, and secure left as default.
Updated test expectations:
Regenerated
CookieSet.expected,InsecureCookie.expected, andCargo.lockviacodeql test run . --learn.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
docs.rscurl -s REDACTED(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.