-
Notifications
You must be signed in to change notification settings - Fork 413
Update deprecation warnings for CodeQL Action to v4 #3272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@henrymercer, could you review this PR? I've got some failing checks and I'm honestly stumped—Copilot wasn't much help either. It seems to consistently fail for these two sets of versions 🤔 Edit: Nevermind |
… to reflect correct deprecation status
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the CodeQL Action version deprecation warning from v3 to v4. The changes prepare users for the upcoming deprecation of CodeQL Action v3 by updating version checks, error messages, and minimum supported GHES version requirements.
- Updates version check logic to warn users running v1, v2, or v3 to upgrade to v4
- Changes minimum GHES version requirement from 3.11 to 3.20 for v4 support
- Updates deprecation message and changelog URL
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/util.ts | Updated checkActionVersion function to check for v4 instead of v3, changed GHES minimum version to 3.20, and updated deprecation message |
| src/util.test.ts | Added test cases for v3 and v4 version checks with various GHES versions, updated expected error message |
| lib/*.js | Generated JavaScript files reflecting the TypeScript changes (auto-generated, not reviewed per guidelines) |
| CHANGELOG.md | Documented the new v3 to v4 migration warning |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
How did/will you validate this change?
.test.tsfiles).pr-checks).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Merge / deployment checklist