Skip to content

Conversation

@chraac
Copy link
Contributor

@chraac chraac commented Nov 12, 2025

Description

This PR introduces a new hex_supported_buffer function to improve buffer support checking in the ggml-hexagon backend.

Changes

  • Refactored buffer support checking: Added a dedicated hex_supported_buffer() function to centralize and improve the logic for determining whether a buffer is supported by the Hexagon backend

Benefits

  • Better maintainability: Centralized buffer support logic makes the codebase easier to maintain and update
  • Improved clarity: The new function provides a clearer and more explicit way to check buffer compatibility
  • Reduced duplication: Eliminates redundant buffer checking code throughout the Hexagon backend

@chraac chraac marked this pull request as draft November 12, 2025 15:38

return hex_supported_buffer(sess, tensors...);
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @max-krasnyansky and @lhez,

What do you think about introducing the hex_supported_buffer() template helper function to minimize code duplication?
This should make it easier to add new ops in the future by providing a consistent, reusable buffer support check. Open to feedback!

@github-actions github-actions bot added the ggml changes relating to the ggml tensor library for machine learning label Nov 12, 2025
@chraac chraac changed the title [WIP] ggml-hexagon: add hex_supported_buffer for better buffer supported check ggml-hexagon: add hex_supported_buffer for better buffer supported check Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ggml changes relating to the ggml tensor library for machine learning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant