-
-
Notifications
You must be signed in to change notification settings - Fork 354
chore: Remove SentryFrameTracker imports #5276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
itaybre
wants to merge
9
commits into
denrase/options-enable-logs
Choose a base branch
from
itay/frames_tracker_swift
base: denrase/options-enable-logs
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Android (new) Performance metrics 🚀
|
Contributor
Android (legacy) Performance metrics 🚀
|
e060ba9 to
d61ca6d
Compare
c9f86eb to
0327771
Compare
e127486 to
b407fd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
This PRs removes SentryFramesTracker.h imports removed in getsentry/sentry-cocoa#6447 and updates the code to use the Swift version.
💡 Motivation and Context
Relates to getsentry/sentry-cocoa#6447
This can only be merged once #5153, #5267 are merged and sentry-cocoa v9 is released.