-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Removed UWP (depricated) #15379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Removed UWP (depricated) #15379
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bundle ReportChanges will decrease total bundle size by 12.49kB (-0.05%) ⬇️. This is within the configured threshold ✅ Detailed changes
ℹ️ *Bundle size includes cached data from a previous commit Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
| { | ||
| source: '/platforms/dotnet/guides/uwp/:path*', | ||
| destination: '/platforms/dotnet/guides/maui/', | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Redirection Chain: UWP to Maui Needs Cleanup
The new redirect for UWP paths creates a redirect chain. There's an existing redirect in src/middleware.ts (line 925) that redirects /platforms/dotnet/uwp/ to /platforms/dotnet/guides/uwp/. When combined with this new redirect from /platforms/dotnet/guides/uwp/:path* to /platforms/dotnet/guides/maui/, users accessing /platforms/dotnet/uwp/ will be redirected twice: first by middleware to /platforms/dotnet/guides/uwp/, then by this redirect to /platforms/dotnet/guides/maui/. The middleware redirect should be removed to create a direct single redirect from /platforms/dotnet/uwp/ to /platforms/dotnet/guides/maui/.
DESCRIBE YOUR PR
Resolves getsentry/sentry-dotnet#4497
IS YOUR CHANGE URGENT?
SLA
cc: @Flash0ver
PRE-MERGE CHECKLIST