fix: deduplicate compiler version normalization #12445
Open
+13
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestoalvarez
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
onbjerg
requested changes
Nov 4, 2025
crates/verify/src/utils.rs
Outdated
Comment on lines
62
to
68
| pub fn version_without_build(version: &str) -> String { | ||
| version.split('+').next().unwrap_or("").to_string() | ||
| } | ||
|
|
||
| pub fn normalize_compiler_version_str(version: &str) -> String { | ||
| version_without_build(version).trim_start_matches('v').to_string() | ||
| } |
There was a problem hiding this comment.
these are only used in this crate, so please do not mark them pub.
please also add a small doc comment explaining what they do so you don't need to look up the fn definition
crates/verify/src/utils.rs
Outdated
Comment on lines
62
to
63
| pub fn version_without_build(version: &str) -> String { | ||
| version.split('+').next().unwrap_or("").to_string() |
There was a problem hiding this comment.
this seems like it should just be an Option<_> since all we do is check if it's empty and then provide a better default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
crates/verify/src/utils.rs.utils.rsandetherscan/mod.rsinstead of inline parsing.Removes duplicated logic (split by '+' and trim leading 'v'), reducing maintenance risk and keeping behavior