add decodertest #139
Draft
add decodertest #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 4, 2025 17:39
ilario-pierbattista
requested changes
Jun 5, 2025
tests/unit/StringDecoderTest.php
Outdated
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Tests\Unit; |
There was a problem hiding this comment.
The test file path should be coherent with the path of StringDecoder
tests/unit/StringDecoderTest.php
Outdated
| $decoder = new StringDecoder(); | ||
| $context = new Context($decoder); | ||
|
|
||
| foreach ([123, 3.14, true] as $input) { |
There was a problem hiding this comment.
Ok, but try to use PHPUnit's data providers
tests/unit/StringDecoderTest.php
Outdated
|
|
||
| foreach ([123, 3.14, true] as $input) { | ||
| $result = $decoder->validate($input, $context); | ||
| $this->assertNotInstanceOf(ValidationSuccess::class, $result); |
There was a problem hiding this comment.
assert on ValidationFailure instance instead
tests/unit/StringDecoderTest.php
Outdated
| $context = new Context($decoder); //cosa controllare | ||
|
|
||
| //il valore da validare passa il controllo? | ||
| $result = $decoder->validate('ciao', $context); |
There was a problem hiding this comment.
You can use directly decode instead of validate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.