Skip to content

Conversation

@MyIgel
Copy link

@MyIgel MyIgel commented Jan 26, 2025

Ayesh and others added 2 commits January 26, 2025 18:33
…r PHP < 7.1

Fixes all issues that emit deprecation notices on PHP 8.4 for implicit nullable parameter type declarations.

See:
 - [RFC](https://wiki.php.net/rfc/deprecate-implicitly-nullable-types)
 - [PHP 8.4: Implicitly nullable parameter declarations deprecated](https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated)

(cherry picked from commit 7b307a9)
@MyIgel
Copy link
Author

MyIgel commented Jan 26, 2025

This could also be the fix for #897 when released

@Evgeny1973
Copy link

@erusev Is there going to be a new release anytime?

@tacman
Copy link

tacman commented Apr 2, 2025

Please don't sacrifice PHP 8.4 compatibility for long-dead versions of PHP or any other library. Anyone still using something that old likely isn't updating this library, but is instead inside of code that hasn't be touched in years.

@u01jmg3
Copy link

u01jmg3 commented Apr 14, 2025

Could this be released as v2? Anyone updating their dependencies would explicitly have to update this dependency to be v2 thus preventing unwanted breakages.

@xPaw
Copy link
Contributor

xPaw commented Apr 30, 2025

To prevent confusion: all these changes are already merged in the master branch. This PR is specifically trying to update the 1.7.x branch.

@tacman
Copy link

tacman commented Apr 30, 2025

Great. A new release would be welcome.

image

@BafS
Copy link

BafS commented May 1, 2025

You can use dev-master to have the latest version compatible with PHP8.4 (not the best practice but there is no other tags)

@LukeWCS
Copy link

LukeWCS commented May 6, 2025

Hi

I'm currently updating a test suite for phpBB extensions, and I'm using this tool, among other things.

Please don't sacrifice PHP 8.4 compatibility for long-dead versions of PHP or any other library.

I agree.

PHP 5 is no longer relevant today, and PHP 7 is also long outdated. You shouldn't implement "complicated" workarounds for outdated PHP versions, especially when the solution to the implicitly nullable problem is very compact and can be solved natively.

edit:

I should read all the comments before writing one myself. ;-) I missed this:

To prevent confusion: all these changes are already merged in the master branch.

Thx @xPaw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants