-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add PHP 8.4 support for 1.7.x by dropping support for PHP < 7.1 #899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 1.7.x
Are you sure you want to change the base?
Conversation
…r PHP < 7.1 Fixes all issues that emit deprecation notices on PHP 8.4 for implicit nullable parameter type declarations. See: - [RFC](https://wiki.php.net/rfc/deprecate-implicitly-nullable-types) - [PHP 8.4: Implicitly nullable parameter declarations deprecated](https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated) (cherry picked from commit 7b307a9)
|
This could also be the fix for #897 when released |
|
@erusev Is there going to be a new release anytime? |
|
Please don't sacrifice PHP 8.4 compatibility for long-dead versions of PHP or any other library. Anyone still using something that old likely isn't updating this library, but is instead inside of code that hasn't be touched in years. |
|
Could this be released as v2? Anyone updating their dependencies would explicitly have to update this dependency to be v2 thus preventing unwanted breakages. |
|
To prevent confusion: all these changes are already merged in the master branch. This PR is specifically trying to update the 1.7.x branch. |
|
You can use dev-master to have the latest version compatible with PHP8.4 (not the best practice but there is no other tags) |
|
Hi I'm currently updating a test suite for phpBB extensions, and I'm using this tool, among other things.
I agree. PHP 5 is no longer relevant today, and PHP 7 is also long outdated. You shouldn't implement "complicated" workarounds for outdated PHP versions, especially when the solution to the implicitly nullable problem is very compact and can be solved natively. edit: I should read all the comments before writing one myself. ;-) I missed this:
Thx @xPaw |

setUpreturn type