-
Notifications
You must be signed in to change notification settings - Fork 117
feat: route-level body mutation for top-level field #1492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Xiaolin Lin <xlin158@bloomberg.net>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1492 +/- ##
==========================================
- Coverage 83.95% 83.93% -0.02%
==========================================
Files 143 144 +1
Lines 12618 12696 +78
==========================================
+ Hits 10594 10657 +63
- Misses 1408 1420 +12
- Partials 616 619 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is not bad and looks a good start. The API still leaves a room for the future addition of more complex jsonpatch style!
cc @tiswanso do you have any comments?
5760eb2 to
df0132a
Compare
Looks like top-level field can solve the use-case cited at here #1386 (reply in thread) already? What is the specific need for jsonpatch deep level field mutation? Wondering if we ever encounter such complex use case for ChatCompletion, Completion or other AI workload APIs. |
|
at least vendor specific fields forced at gateway would be the use case, i.e. any field in https://aigateway.envoyproxy.io/docs/capabilities/llm-integrations/vendor-specific-fields/ so the path might be nested at least not necessarily require jsonpatch though |
Signed-off-by: Xiaolin Lin <xlin158@bloomberg.net>
df0132a to
bf33ec0
Compare
|
had to force-push due to one of commits wasn't signed. |
Signed-off-by: Xiaolin Lin <xlin158@bloomberg.net>
Description
Support route-level body mutation for top-level field. route level body mutation is useful when have heterogeneous cloud-provider backends support same model but with slightly different request body fields to override esp OpenAI's
service_tierfieldRelated Issues/PRs (if applicable)
Close #1481