Skip to content

Conversation

@hustxiayang
Copy link
Contributor

Description

Index of choice was always set as 0. In vertex api, it would return several parts in one chunk

Signed-off-by: yxia216 <yxia216@bloomberg.net>
@hustxiayang hustxiayang requested a review from a team as a code owner November 4, 2025 13:58
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 4, 2025
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.96%. Comparing base (40fa3d6) to head (f347c33).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1487   +/-   ##
=======================================
  Coverage   83.95%   83.96%           
=======================================
  Files         143      143           
  Lines       12618    12618           
=======================================
+ Hits        10594    10595    +1     
+ Misses       1408     1406    -2     
- Partials      616      617    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hustxiayang
Copy link
Contributor Author

/retest

1 similar comment
@hustxiayang
Copy link
Contributor Author

/retest

@hustxiayang
Copy link
Contributor Author

#1478

@nacx
Copy link
Contributor

nacx commented Nov 4, 2025

Could you please add unit tests so that we don't break this by mistake in the future?

@yuzisun
Copy link
Contributor

yuzisun commented Nov 4, 2025

will merge after adding the test

@hustxiayang
Copy link
Contributor Author

@nacx Sure, would add it. Thanks a lot for the comment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants