Skip to content

Conversation

@hustxiayang
Copy link
Contributor

Description

Finish reason should be tool calls if the model returns a tool call response. In vertex api, there is no tool call finish reason, thus need a work around to make it compatible.

Signed-off-by: yxia216 <yxia216@bloomberg.net>
@hustxiayang hustxiayang requested a review from a team as a code owner November 4, 2025 13:56
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 4, 2025
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.97%. Comparing base (40fa3d6) to head (0fac71b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1486      +/-   ##
==========================================
+ Coverage   83.95%   83.97%   +0.01%     
==========================================
  Files         143      143              
  Lines       12618    12622       +4     
==========================================
+ Hits        10594    10599       +5     
+ Misses       1408     1406       -2     
- Partials      616      617       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: yxia216 <yxia216@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants