Fix SearchExecutionContextTests.testFielddataLookupSomtimesLoop #137595
+14
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
v9.3.0
needs:triage
chrisparrinello
added
>test
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
benchaplin
approved these changes
Nov 5, 2025
| runtimeField("1", leafLookup -> leafLookup.doc().get("2").get(0).toString()), | ||
| runtimeField("2", leafLookup -> leafLookup.doc().get("3").get(0).toString()), | ||
| runtimeField("3", leafLookup -> leafLookup.doc().get("4").get(0).toString()), | ||
| runtimeField("4", (leafLookup, docId) -> { |
| try (Directory directory = newDirectory(); RandomIndexWriter indexWriter = new RandomIndexWriter(random(), directory)) { | ||
| indexWriter.addDocument(List.of(new StringField("indexed_field", "first", Field.Store.NO))); | ||
| indexWriter.addDocument(List.of(new StringField("indexed_field", "second", Field.Store.NO))); | ||
| indexWriter.addDocument(List.of(new KeywordField("indexed_field", "first", Field.Store.YES))); |
There was a problem hiding this comment.
You sure this doesn't mess with other tests that use this method? I would run @Repeat on the suite to be sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #136766.
The test creates a cycle in runtime fields that is broken if the doc with
docId == 0's field4is accessed. The first part of the test attempts to only fetch the document withindexed_fieldfirstwhich should not fail because the runtime fields would not have a loop sincefirstshould havedocId == 0. The second part fetches all of the documents which should fail since all of the documents are fetched and the runtime fields are calculated.The random seed used in the failing test results in the document with
firstactually getting adocIdof 1 causing the test to fail. Since we can't depend ondocIdto break the cycle in the runtime fields, changes were made to be able to useindexed_field == "first"to break the cycle in the first part of the test.