ES|QL - vector similarity pushdown follow up #137564
Open
+297
−168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 3, 2025 20:21
…sure no duplicate names
carlosdelest
added
>non-issue
:SearchOrg/Relevance
carlosdelest
commented
Nov 4, 2025
| similarityFunction.dataType(), | ||
| blockLoaderFunctionConfig | ||
| ); | ||
| var name = rawTemporaryName(fieldAttr.name(), blockLoaderFunctionConfig.name()); |
There was a problem hiding this comment.
Rely on blockLoaderFunctionConfig.name() to get a unique name for different functions
|
@elasticsearchmachine run elasticsearch-ci/bwc-snapshots-part3 |
elasticsearchmachine
added
the
Team:Search - Relevance
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
|
Pinging @elastic/search-relevance (Team:Search - Relevance) |
nik9000
reviewed
Nov 4, 2025
| @Override | ||
| protected Expression rule(VectorSimilarityFunction vectorSimilarityFunction, LogicalOptimizerContext ctx) { | ||
| return vectorSimilarityFunction.canonical(); | ||
| } |
There was a problem hiding this comment.
I had assumed there was already a rule for this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #137392
Addresses the following follow ups to #137002:
ResolveUnionTypesworkcanonicalizefor vector similarity functions, and addsCanonicalizeVectorSimilarityFunctionsrule to ensure canonicalizationBlockLoaderFunctionConfignow implementsname(), to help create a distinct name for the pushed downFieldAttribute- which is needed in order not to have duplicate field names