-
Notifications
You must be signed in to change notification settings - Fork 198
Updating otel gateway config sample #10959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Adding the new `elasticapm` processor to the rest of signals.
|
This pull request does not have a backport label. Could you fix it @LikeTheSalad? 🙏
|
|
@LikeTheSalad I think we should at least backport to 9.2. To which versions can this apply? |
Good point, I've added the label. Thanks! |
|
Would be nice to roll this out in 9.2.1 I guess, and first get a review from the Collector team. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After seeing the other discussion from the internally linked repo, I'm not sure we want to do this either.
This would mean that every single log and metric will be enriched with basically apm related fields. So let's say if a service only sends otel logs, and don't really use apm, then we'd still add a bunch of fields, which may not be needed.
@LikeTheSalad what's the exact use-case here?
I know mobile agents rely on logs for lots of things... is that maybe the reason?
Could we maybe handle this by providing a dedicated pipeline for those agents where we enrich logs and metrics, but then keep the general pipeline without this enrichment?
Also.. should we add to both, or would only log enrichment be enough?
Yes. The mobile UI dashboards rely on enriched logs.
I'm not sure about the deeper details of the EDOT Collector, but I guess as long as there's a way for users to send their mobile telemetry data in a way that logs are also enriched, it works for me.
For mobile use cases, logs are enough. And I can't foresee a use case that would need enriched metrics. The reason I added them is because the |
What does this PR do?
Adding the new
elasticapmprocessor to the rest of signals in the gateway configuration sample.Why is it important?
The new processor,
elasticapm, was created to support all signals, not only traces. However, the outcome is the same as if it only supported traces if we don't encourage users to add it to other signals as well.Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature works./changelog/fragmentsusing the changelog toolI have added an integration test or an E2E testDisruptive User Impact
How to test this PR locally
Related issues
Questions to ask yourself