Skip to content

Add M5 iPad Pro models #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Add M5 iPad Pro models #467

wants to merge 5 commits into from

Conversation

Copy link
Contributor

Copilot AI commented Nov 9, 2025 •
edited
Loading

Plan: Add M5 iPad Pro Models ✅

Based on the issue requirements and exploration, here's the minimal-change plan:

  • Explore repository structure and understand device addition process
  • Add M5 CPU definition to Device.swift.gyb
  • Add 2 new M5 iPad Pro device entries to Device.swift.gyb:
    • iPad Pro 11-inch (M5) - covers Wi-Fi and Wi-Fi + Cellular variants via model identifiers
    • iPad Pro 13-inch (M5) - covers Wi-Fi and Wi-Fi + Cellular variants via model identifiers
  • Regenerate Device.generated.swift using gyb tool
  • Add unreleased changelog entry for M5 iPads
  • Add tests for M5 iPad Pro models
  • Verify all changes are correct
  • Run code review (no uncommitted changes to review)
  • Run CodeQL security check (no security issues, configuration-only changes)
  • Fix changelog year (2024 -> 2025)
  • Remove sourceLocation comments from generated file

Summary

Successfully added support for M5 iPad Pro models announced by Apple on October 15, 2025:

Changes Made:

  1. Device.swift.gyb: Added M5 CPU definition and two M5 iPad Pro device entries
  2. Device.generated.swift: Regenerated with gyb tool using --line-directive '' flag to remove sourceLocation comments (reduced from 3,975 to 2,720 lines)
  3. CHANGELOG.md: Added unreleased section documenting the new M5 iPad Pro models (corrected year to 2025)
  4. Tests.swift: Added comprehensive tests for M5 CPU and device properties

Device Details:

  • iPad Pro 11-inch (M5): Model identifiers iPad17,3 (Wi-Fi) and iPad17,4 (Wi-Fi + Cellular)
  • iPad Pro 13-inch (M5): Model identifiers iPad17,5 (Wi-Fi) and iPad17,6 (Wi-Fi + Cellular)
  • CPU: M5 chip
  • Properties: Pro device, 5G support, LiDAR sensor, USB-C connectivity
  • Specs: Same physical dimensions and PPI as M4 models

Verification:

✅ Device cases properly defined
✅ Model identifiers correctly mapped
✅ M5 CPU definition added
✅ Included in allProDevices array
✅ 10 test assertions added
✅ Changelog updated with correct year (October 2025)
✅ All sourceLocation comments removed (1,257 lines cleaned up)
✅ All generated code validated
✅ No security issues detected

Original prompt

This section details on the original issue you should resolve

<issue_title>Add M5 iPad models</issue_title>
<issue_description>Apple released new 11- and 13-inch M5 iPad Pros on October 15. These should be added to DeviceKit.

Models:
iPad Pro 11-inch (M5) Wi-Fi
iPad Pro 13-inch (M5) Wi-Fi
iPad Pro 11-inch (M5) Wi-Fi + Cellular
iPad Pro 13-inch (M5) Wi-Fi + Cellular

Tech specs:
https://support.apple.com/en-us/125406</issue_description>

<agent_instructions>Also add unreleased changelog item. Use the build tool to generate the swift file. Only make manual edits to the gyb file.</agent_instructions>

Comments on the Issue (you are @copilot in this section)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI self-assigned this Nov 9, 2025
@Zandor300
Add M5 iPad Pro models and M5 CPU definition
5f115e1 
Co-authored-by: Zandor300 <6069593+Zandor300@users.noreply.github.com>
Zandor300
Zandor300 requested changes Nov 9, 2025
View reviewed changes
CHANGELOG.md Outdated

## Unreleased

### New October 2024 devices
Copy link
Member

@Zandor300 Zandor300 Nov 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### New October 2024 devices
### New October 2025 devices

Copy link
Member

@Zandor300 Zandor300 Nov 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot please fix this

Copy link
Contributor Author

Copilot AI Nov 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in commit c8f9b37. Changed "October 2024" to "October 2025" to match the release timeline.

@Zandor300
Add tests for M5 iPad Pro models and M5 CPU
34b2d56 
Co-authored-by: Zandor300 <6069593+Zandor300@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Nov 9, 2025 •
edited
Loading

17 Warnings
⚠️ PR is classed as Work in Progress
⚠️ Big PR, consider splitting into smaller
⚠️ Plist changed, don't forget to localize your plist values
⚠️ Source/Device.generated.swift#L1018 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:1018
⚠️ Source/Device.generated.swift#L1853 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:1853
⚠️ Source/Device.generated.swift#L2246 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:2246
⚠️ Source/Device.generated.swift#L2558 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:2558
⚠️ Source/Device.generated.swift#L2850 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:2850
⚠️ Source/Device.generated.swift#L3864 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:3864
⚠️ Source/Device.generated.swift#L3969 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:3969
⚠️ Tests/Tests.swift#L463 - Collection literals should not have trailing commas.
trailing_comma Tests.swift:463
⚠️ Tests/Tests.swift#L496 - Collection literals should not have trailing commas.
trailing_comma Tests.swift:496
⚠️ Tests/Tests.swift#L531 - Collection literals should not have trailing commas.
trailing_comma Tests.swift:531
⚠️ Tests/Tests.swift#L538 - Function body should span 40 lines or less excluding comments and whitespace: currently spans 44 lines
function_body_length Tests.swift:538
⚠️ Tests/Tests.swift#L580 - Collection literals should not have trailing commas.
trailing_comma Tests.swift:580
⚠️ Tests/Tests.swift#L668 - Collection literals should not have trailing commas.
trailing_comma Tests.swift:668
⚠️ Tests/Tests.swift#L709 - Collection literals should not have trailing commas.
trailing_comma Tests.swift:709

SwiftLint found issues

Warnings

File Line Reason
Tests.swift 538 Function body should span 40 lines or less excluding comments and whitespace: currently spans 44 lines (function_body_length)
Tests.swift 463 Collection literals should not have trailing commas. (trailing_comma)
Tests.swift 496 Collection literals should not have trailing commas. (trailing_comma)
Tests.swift 531 Collection literals should not have trailing commas. (trailing_comma)
Tests.swift 580 Collection literals should not have trailing commas. (trailing_comma)
Tests.swift 668 Collection literals should not have trailing commas. (trailing_comma)
Tests.swift 709 Collection literals should not have trailing commas. (trailing_comma)
Device.generated.swift 1018 TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift 1853 TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift 2246 TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift 2558 TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift 2850 TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift 3864 TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift 3969 TODOs should be resolved (Replace with proper implementa...). (todo)

Generated by 🚫 Danger

Copilot AI changed the title [WIP] Add M5 iPad models to DeviceKit Add M5 iPad Pro models Nov 9, 2025
Copilot AI requested a review from Zandor300 November 9, 2025 20:55
Copilot finished work on behalf of Zandor300 November 9, 2025 20:55
@Zandor300
Fix changelog year: October 2024 -> October 2025
bee149c 
Co-authored-by: Zandor300 <6069593+Zandor300@users.noreply.github.com>
Copilot finished work on behalf of Zandor300 November 9, 2025 23:25
@Zandor300
Copy link
Member

Zandor300 commented Nov 19, 2025

@copilot Please remove all sourceLocation comments inside the generated Swift file.

@Zandor300
Remove sourceLocation comments from generated Swift file
5cb041a 
Co-authored-by: Zandor300 <6069593+Zandor300@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Nov 19, 2025

@copilot Please remove all sourceLocation comments inside the generated Swift file.

Removed all sourceLocation comments in commit 5cb041a. Regenerated Device.generated.swift using --line-directive '' flag, reducing the file from 3,975 to 2,720 lines (1,257 lines removed).

Copilot finished work on behalf of Zandor300 November 19, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zandor300 Zandor300 Awaiting requested review from Zandor300

Requested changes must be addressed to merge this pull request.

Assignees

@Zandor300 Zandor300

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add M5 iPad models

2 participants

@Zandor300