Skip to content

Fix buffer overflow in get_term_size() when using TIOCGWINSZ ioctl #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2025
Merged

Fix buffer overflow in get_term_size() when using TIOCGWINSZ ioctl #342

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b47be5e
Fix buffer overflow in get_term_size()
Nov 5, 2025
c1522a7
Polish the get_term_size code
cyrus-and Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .gdbinit
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,11 +612,13 @@ class Dashboard(gdb.Command):
else:
import termios
import fcntl
# first 2 shorts (4 byte) of struct winsize
raw = fcntl.ioctl(fd, termios.TIOCGWINSZ, ' ' * 4)
height, width = struct.unpack('hh', raw)
# first 2 shorts of struct winsize
winsize_format = 'hhhh'
buffer = b'\x00' * struct.calcsize(winsize_format)
buffer = fcntl.ioctl(fd, termios.TIOCGWINSZ, buffer)
height, width, _, _ = struct.unpack(winsize_format, buffer)
return int(width), int(height)
except (ImportError, OSError):
except (ImportError, OSError, SystemError):
# this happens when no curses library is found on windows or when
# the terminal is not properly configured
return 80, 24 # hardcoded fallback value
Expand Down