Migrate team payment components to TypeScript #3123

rohitpaulk · 2025-09-24T01:30:32Z

Checklist:

I've thoroughly self-reviewed my changes
I've added tests for my changes, unless they affect admin-only areas (or are otherwise not worth testing)
I've verified any visual changes using Percy (add a commit with [percy] in the message to trigger)

Migrate `app/components/team-payment-page` components to TypeScript

This PR migrates all components within app/components/team-payment-page and its subdirectories from JavaScript to TypeScript.

The primary goal is to enhance type safety, improve maintainability, and enable better tooling support for these components.

Key changes include:

Conversion of all .js component files to .ts.
Introduction of Signature interfaces for precise typing of component arguments, elements, and blocks.
Proper typing for services using @service declare.
Removal of {{! @glint-nocheck: not typesafe yet }} and {{! @glint-expect-error: not ts-ified yet }} comments from templates, leveraging Glint for template type checking.
Resolution of all linting and TypeScript errors to ensure a clean codebase.

This migration ensures that the team-payment-page components are fully type-safe and align with our TypeScript standards.

Slack Thread

Co-authored-by: rohitpaulk <rohitpaulk@gmail.com>

cursor · 2025-09-24T01:30:33Z

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

github-actions · 2025-09-24T01:33:15Z

Test Results

1 files ±0 1 suites ±0 9m 46s ⏱️ - 4m 49s
659 tests - 5 610 ✅ - 5 48 💤 ±0 0 ❌ ±0 1 🔥 ±0
659 runs - 5 609 ✅ - 5 48 💤 ±0 1 ❌ ±0 1 🔥 ±0

For more details on these errors, see this check.

Results for commit f86626f. ± Comparison against base commit 4f65226.

This pull request removes 6 and adds 1 tests. Note that renamed tests count towards both.

Chrome 140.0 ‑ Acceptance | course-admin | view-submissions: it should be able to filter by stage(s) through a dropdown menu
Chrome 140.0 ‑ Acceptance | course-admin | view-submissions: it should be accessible if user is course author and authored current course
Chrome 140.0 ‑ Acceptance | course-admin | view-submissions: it should handle null value for tree SHA
Chrome 140.0 ‑ Acceptance | course-admin | view-submissions: it should have the commit SHA in the header
Chrome 140.0 ‑ Acceptance | course-admin | view-submissions: it should have the tree SHA in the header
Chrome 140.0 ‑ Acceptance | course-admin | view-submissions: it should not be accessible if user is course author and did not author current course

Chrome ‑ error

♻️ This comment has been updated with latest results.

codecov · 2025-09-24T01:33:19Z

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
611	1	610	48

View the full list of 1 ❄️ flaky test(s)

Chrome::error

Flake rate in main: 100.00% (Passed 0 times, Failed 4 times)

Stack Traces | 0s run time

Error: Browser timeout exceeded: 10s
Error while executing test: Acceptance | course-admin | view-submissions: it should be able to filter by stage(s) through a dropdown menu
Stderr: 
 [3107:3457:0924/040312.386305:ERROR:dbus/bus.cc:408] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
[3107:3457:0924/040316.792450:ERROR:dbus/bus.cc:408] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")

DevTools listening on ws://127.0.0.1:.../devtools/browser/d1a7ff6e-1631-42dc-821a-ac15cf41e0de
[3107:3457:0924/040317.974854:ERROR:dbus/bus.cc:408] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
[3107:3107:0924/040318.619006:ERROR:dbus/object_proxy.cc:573] Failed to call method: org.freedesktop.DBus.NameHasOwner: object_path= ............................../org/freedesktop/DBus: unknown error type: 
[3107:3457:0924/040318.619484:ERROR:dbus/bus.cc:408] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
[3107:3457:0924/040318.619510:ERROR:dbus/bus.cc:408] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
[3107:3457:0924/040318.619515:ERROR:dbus/bus.cc:408] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
[3107:3457:0924/040318.619518:ERROR:dbus/bus.cc:408] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
[3107:3457:0924/040318.650740:ERROR:dbus/bus.cc:408] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
[3107:3457:0924/040318.650761:ERROR:dbus/bus.cc:408] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
[3107:3107:0924/040318.686221:ERROR:dbus/object_proxy.cc:573] Failed to call method: org.freedesktop.DBus.NameHasOwner: object_path= ............................../org/freedesktop/DBus: unknown error type: 
[3107:3107:0924/040318.698586:ERROR:dbus/object_proxy.cc:573] Failed to call method: org.freedesktop.DBus.NameHasOwner: object_path= ............................../org/freedesktop/DBus: unknown error type: 
[3107:3457:0924/040318.698809:ERROR:dbus/bus.cc:408] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
[3107:3107:0924/040318.741792:ERROR:dbus/object_proxy.cc:573] Failed to call method: org.freedesktop.DBus.NameHasOwner: object_path= ............................../org/freedesktop/DBus: unknown error type: 
[3107:3107:0924/040318.741815:ERROR:dbus/object_proxy.cc:573] Failed to call method: org.freedesktop.DBus.NameHasOwner: object_path= ............................../org/freedesktop/DBus: unknown error type: 
[3107:3107:0924/040318.741943:ERROR:dbus/object_proxy.cc:573] Failed to call method: org.freedesktop.DBus.NameHasOwner: object_path= ............................../org/freedesktop/DBus: unknown error type: 
[3107:3107:0924/040318.749100:ERROR:dbus/object_proxy.cc:573] Failed to call method: org.freedesktop.DBus.NameHasOwner: object_path= ............................../org/freedesktop/DBus: unknown error type: 
[3107:3457:0924/040318.749149:ERROR:dbus/bus.cc:408] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
[3107:3107:0924/040318.751888:ERROR:dbus/object_proxy.cc:573] Failed to call method: org.freedesktop.DBus.Properties.GetAll: object_path= .../UPower/devices/DisplayDevice: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files
[3107:3107:0924/040318.786075:ERROR:dbus/object_proxy.cc:573] Failed to call method: org.freedesktop.DBus.NameHasOwner: object_path= ............................../org/freedesktop/DBus: unknown error type: 
[3107:3457:0924/040318.786348:ERROR:dbus/bus.cc:408] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
[3107:3107:0924/040318.815944:ERROR:dbus/object_proxy.cc:573] Failed to call method: org.freedesktop.DBus.NameHasOwner: object_path= ............................../org/freedesktop/DBus: unknown error type: 
[3107:3457:0924/040318.816016:ERROR:dbus/bus.cc:408] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
[3107:3107:0924/040318.817843:ERROR:dbus/object_proxy.cc:573] Failed to call method: org.freedesktop.DBus.NameHasOwner: object_path= ............................../org/freedesktop/DBus: unknown error type: 
[3107:3495:0924/040400.233899:ERROR:.../gcm/engine/registration_request.cc:291] Registration response error message: DEPRECATED_ENDPOINT
Created TensorFlow Lite XNNPACK delegate for CPU.

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

codecov · 2025-09-24T01:33:59Z

Bundle Report

Changes will increase total bundle size by 70 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
client-array-push	38.59MB	70 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: client-array-push

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`assets/chunk.*.js`	70 bytes	3.18MB	0.0%

rohitpaulk · 2025-09-24T03:50:49Z

@cursor fix lint errors

cursor · 2025-09-24T03:51:00Z

I refined the team payment details step by improving input handling for the number of seats and addressing Glint type errors, ensuring better data binding and developer experience.

I implemented a numberOfSeatsAsString getter in app/components/team-payment-page/team-details-step-container.ts to provide a string representation of the number of seats.
I updated app/components/team-payment-page/team-details-step-container.hbs to bind the seat count input's @value to this.numberOfSeatsAsString, correctly handling string-typed HTML input values.
I added {{! @glint-expect-error }} comments in app/components/team-payment-page/team-details-step-container.hbs to suppress Glint errors for @teamPaymentFlow.isSaving, acknowledging a type mismatch.
I removed the role="presentation" attribute from the check SVG in app/components/team-payment-page/navigation-container-item.hbs for minor cleanup.

_{Learn more about Cursor Agents}

Co-authored-by: rohitpaulk <rohitpaulk@gmail.com>

Refactor: Convert team payment page components to TypeScript

17a00d8

Co-authored-by: rohitpaulk <rohitpaulk@gmail.com>

vercel bot deployed to Preview – frontend September 24, 2025 01:33 View deployment

vercel bot deployed to Preview – frontend-stg September 24, 2025 01:34 View deployment

Refactor team details form for better input handling

f86626f

Co-authored-by: rohitpaulk <rohitpaulk@gmail.com>

vercel bot deployed to Preview – frontend September 24, 2025 04:04 View deployment

vercel bot deployed to Preview – frontend-stg September 24, 2025 04:05 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Migrate team payment components to TypeScript #3123

Migrate team payment components to TypeScript #3123

Uh oh!

rohitpaulk commented Sep 24, 2025

Uh oh!

cursor bot commented Sep 24, 2025

Uh oh!

github-actions bot commented Sep 24, 2025 •

edited

Loading

Uh oh!

codecov bot commented Sep 24, 2025 •

edited

Loading

Uh oh!

codecov bot commented Sep 24, 2025 •

edited

Loading

Assets Changed:

Uh oh!

rohitpaulk commented Sep 24, 2025

Uh oh!

cursor bot commented Sep 24, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Migrate team payment components to TypeScript #3123

Are you sure you want to change the base?

Migrate team payment components to TypeScript #3123

Uh oh!

Conversation

rohitpaulk commented Sep 24, 2025

Migrate app/components/team-payment-page components to TypeScript

Uh oh!

cursor bot commented Sep 24, 2025

Uh oh!

github-actions bot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

codecov bot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 1 Tests Failed:

Uh oh!

codecov bot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

rohitpaulk commented Sep 24, 2025

Uh oh!

cursor bot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Migrate `app/components/team-payment-page` components to TypeScript

github-actions bot commented Sep 24, 2025 •

edited

Loading

codecov bot commented Sep 24, 2025 •

edited

Loading

codecov bot commented Sep 24, 2025 •

edited

Loading

cursor bot commented Sep 24, 2025 •

edited

Loading