feat: add max_file_size support to AzureBlob source #1259
Merged
+33
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add optional max_file_size parameter to filter files by size in both list() and get_value() APIs. Files exceeding the limit are treated as non-existent. Closes cocoindex-io#1251
Member
|
Hi @prabhath004 thanks for the PR. Tests don't pass - seems Rust build failure. Please fix. Thanks! |
Azure blob content_length is u64, not Option<u64>, so compare directly with max_size cast to u64 instead of unwrapping Option.
Contributor
Author
|
@georgeh0 Yeah, I have made the changes. There was a small error. I think it should work now! |
georgeh0
approved these changes
Nov 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
max_file_sizeparameter to AzureBlob source for filtering large files.Files exceeding the size limit are treated as non-existent in both list() and get_value() APIs.
Closes #1251