feat(enum): add Enum type engine+python #1218
Conversation
| Str, | ||
|
|
||
| /// Enumerated symbolic value. | ||
| Enum, |
There was a problem hiding this comment.
We should keep a bunch of allowed enum values here (as strings). The information is needed to create JSON schema, etc.
There was a problem hiding this comment.
Thanks! Variants are field-specific, so I stored them.
JSON Schema already reads this and emits "enum".
I can add a typed accessor EnrichedValueType::enum_variants() and a ENUM_VARIANTS_ATTR const to avoid magic strings.
If you’d rather model it as BasicValueType::Enum { variants: Option<Vec<String>> }, happy to refactor.
There was a problem hiding this comment.
I see. Thanks for the explanation.
I think putting it into BasicValueType is better than using attributes. Attributes are not part of the value type - more like some additional annotations. In most type systems, enum variants is part of the type (similar to variants of union type).
think we should go with BasicValueType::Enum(EnumTypeSchema), and EnumTypeSchema has a variants: Vec<Arc<str>> member.
| Str, | ||
|
|
||
| /// Enumerated symbolic value. | ||
| Enum, |
There was a problem hiding this comment.
I see. Thanks for the explanation.
I think putting it into BasicValueType is better than using attributes. Attributes are not part of the value type - more like some additional annotations. In most type systems, enum variants is part of the type (similar to variants of union type).
think we should go with BasicValueType::Enum(EnumTypeSchema), and EnumTypeSchema has a variants: Vec<Arc<str>> member.
| def Enum(*, variants: Optional[Sequence[str]] = None) -> Any: | ||
| """ | ||
| String-like enumerated type. Use `variants` to hint allowed values. | ||
| Example: | ||
| color: Enum(variants=["red", "green", "blue"]) | ||
| At runtime this is a plain `str`; `variants` are emitted as schema attrs. | ||
| """ | ||
| if variants is not None: | ||
| return Annotated[str, TypeKind("Enum"), TypeAttr("variants", list(variants))] | ||
| return Annotated[str, TypeKind("Enum")] | ||
|
|
||
|
|
There was a problem hiding this comment.
We probably don't need this. Users can directly use Python's native way to represent enums, similar to union type.
2 participants
Implements Enum basic type in engine + Python SDK, adds variants attr; updates JSON Schema and docs. Tests & pre-commit pass. Related: #523