logical: enable crud writer by default #156935
Merged
+16
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffswenson
requested review from
kev-cao and
msbutler
and removed request for
a team
|
This change is |
stevendanna
approved these changes
Nov 5, 2025
This change enables the crud writer by default for IMMEDIATE and VALIDATED mode LDR jobs. Release note: LDR now supports partial indexes and is tolerant of mismatched column ids in the source and destination tables. Epic: CRDB-51533
jeffswenson
force-pushed
the
jeffswenson-enable-crud-writer
branch
from
b6da592 to
0d92aa9
Compare
|
Thanks for the reviews! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Nov 5, 2025
156935: logical: enable crud writer by default r=jeffswenson a=jeffswenson This change enables the crud writer by default for IMMEDIATE and VALIDATED mode LDR jobs. Release note: LDR now supports partial indexes and is tolerant of mismatched column ids in the source and destination tables. Epic: CRDB-51533 156939: gossip: fix gossip.callbacks.pending_duration time metric r=pav-kv a=stevendanna In 32723e5 I reversed this subtraction somehow. Release note (bug fix): Fix bug that could result in incorrect gossip.callbacks.pending_duration metric value being recorded. Co-authored-by: Jeff Swenson <jeffswenson@betterthannull.com> Co-authored-by: Steven Danna <danna@cockroachlabs.com>
|
Build failed (retrying...): |
craig bot
pushed a commit
that referenced
this pull request
Nov 5, 2025
155033: asim: use kvserver.LoadBasedRebalancingObjective r=wenyihu6 a=wenyihu6 Previously, LBRebalancingObjective was part of the simulation settings, using QPS as the load rebalance objective. However, the cluster setting kvserver.LoadBasedRebalancingObjective defaults to CPU rebalancing instead. This commit updates asim to rely on the cluster setting, adopting the default cluster setting configuration. Epic: CRDB-55052 Release note: none Resolves: #154512 156594: backup: test adding/dropping database in cluster backup and restore r=jeffswenson a=msbutler Epic: None Release note: none 156876: rttanalysis: deflake BenchmarkJobs r=rafiss a=rafiss The benchmark started failing since the code doesn't handle a nil table descriptor. The fix is to create a dummy descriptor in the job payload details. fixes #151302 Release note: None 156935: logical: enable crud writer by default r=jeffswenson a=jeffswenson This change enables the crud writer by default for IMMEDIATE and VALIDATED mode LDR jobs. Release note: LDR now supports partial indexes and is tolerant of mismatched column ids in the source and destination tables. Epic: CRDB-51533 156942: server: make mma Allocator calls more visible r=wenyihu6 a=tbg They were kind of hidden before, and it has been tripping me up every now and then for a while. The problem was that NewAllocatorState returns a private struct directly, so a bunch of the calls later in the method do not show up when you look at the call hierarchy for the Allocator interface. This is now fixed. Epic: CRDB-55052. 156943: workflow: backport stale action should mark PRs stale after 14 days r=RaduBerinde a=rail Previously, the backport stale action marked PRs as stale after 21 days of inactivity. This change updates the configuration to mark PRs as stale after 14 days of inactivity, ensuring that stale backport PRs are identified and addressed more promptly. Epic: none Release note: none Co-authored-by: wenyihu6 <wenyi@cockroachlabs.com> Co-authored-by: Michael Butler <butler@cockroachlabs.com> Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com> Co-authored-by: Jeff Swenson <jeffswenson@betterthannull.com> Co-authored-by: Tobias Grieger <tobias.b.grieger@gmail.com> Co-authored-by: Rail Aliiev <rail@iqchoice.com>
|
Build failed (retrying...): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables the crud writer by default for IMMEDIATE and VALIDATED mode LDR jobs.
Release note: LDR now supports partial indexes and is tolerant of mismatched column ids in the source and destination tables.
Epic: CRDB-51533