Add input validation and improve error handling #126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem?
Code review flagged a bunch of error handling issues. Basically, we weren't validating inputs properly, so users would get cryptic NPEs instead of helpful error messages. CI was also failing silently in some cases which made debugging a pain.
What did I change?
Java code
CI workflow
continue-on-error: falseto be explicit about error handlingConfig docs
Why does this matter?
Testing
Manually tested with:
Should probably add unit tests for the validation logic but wanted to get this out first.
Screenshots/Examples
Before:
NullPointerException at line 47After:
IllegalArgumentException: Violation report path cannot be null or emptyMuch better 👍