Issue #102: add support for sarif reports #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdiachenko
commented
Oct 23, 2025
romani
requested changes
Oct 24, 2025
src/test/java/org/checkstyle/autofix/recipe/AbstractRecipeTestSupport.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| private int getColumn(Region region) { | ||
| int result = -1; |
There was a problem hiding this comment.
Should we do optional? Not a magic "-1".
We can make all optional if we think we can not trust structure of file
There was a problem hiding this comment.
done
column is the only thing, which should be optional. I still default to -1 within the CheckstyleViolation, since xml parser also uses this default
There was a problem hiding this comment.
If value is present as -1 in report, it is present there.
Optional here would be good if report doesn't have such key/value at all, it is json and all of them are optional fields.
So our model will just reflect json nature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #102