[DBOPS-31] Add CSV importer/exporter to DbSeeder #6534
Draft
+6,898
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New Issues (16)Checkmarx found the following issues in this Pull Request
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6534 +/- ##
=======================================
Coverage 52.27% 52.27%
=======================================
Files 1909 1909
Lines 84598 84598
Branches 7558 7558
=======================================
Hits 44223 44223
Misses 38659 38659
Partials 1716 1716 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| using var command = new NpgsqlCommand(query, _connection); | ||
| command.Parameters.AddWithValue("tableName", tableName); | ||
|
|
||
| using var reader = command.ExecuteReader(); |
Check failure
Code scanning / Checkmarx One
Second Order SQL Injection Critical
| using var command = new NpgsqlCommand(query, _connection); | ||
| command.Parameters.AddWithValue("tableName", tableName); | ||
|
|
||
| using var reader = command.ExecuteReader(); |
Check failure
Code scanning / Checkmarx One
Second Order SQL Injection Critical
| using var command = new NpgsqlCommand(query, _connection); | ||
| command.Parameters.AddWithValue("tableName", tableName); | ||
|
|
||
| using var reader = command.ExecuteReader(); |
Check failure
Code scanning / Checkmarx One
Second Order SQL Injection Critical
| query += " ORDER BY TABLE_NAME"; | ||
|
|
||
| using var command = new SqlCommand(query, _connection); | ||
| using var reader = command.ExecuteReader(); |
Check failure
Code scanning / Checkmarx One
Second Order SQL Injection Critical
| query += " ORDER BY TABLE_NAME"; | ||
|
|
||
| using var command = new SqlCommand(query, _connection); | ||
| using var reader = command.ExecuteReader(); |
Check failure
Code scanning / Checkmarx One
Second Order SQL Injection Critical
|
|
||
| importer.DisableForeignKeys(); | ||
|
|
||
| var csvFiles = Directory.GetFiles(_config.CsvSettings.OutputDir, "*.csv"); |
Check failure
Code scanning / Checkmarx One
Second Order SQL Injection Critical
|
|
||
| importer.DisableForeignKeys(); | ||
|
|
||
| var csvFiles = Directory.GetFiles(_config.CsvSettings.OutputDir, "*.csv"); |
Check failure
Code scanning / Checkmarx One
Second Order SQL Injection Critical
| var reporter = new VerificationReporter(_loggerFactory.CreateLogger<VerificationReporter>()); | ||
| reporter.StartVerification(); | ||
|
|
||
| var csvFiles = Directory.GetFiles(_config.CsvSettings.OutputDir, "*.csv"); |
Check failure
Code scanning / Checkmarx One
Second Order SQL Injection Critical
| var reporter = new VerificationReporter(_loggerFactory.CreateLogger<VerificationReporter>()); | ||
| reporter.StartVerification(); | ||
|
|
||
| var csvFiles = Directory.GetFiles(_config.CsvSettings.OutputDir, "*.csv"); |
Check failure
Code scanning / Checkmarx One
Second Order SQL Injection Critical
| var reporter = new VerificationReporter(_loggerFactory.CreateLogger<VerificationReporter>()); | ||
| reporter.StartVerification(); | ||
|
|
||
| var csvFiles = Directory.GetFiles(_config.CsvSettings.OutputDir, "*.csv"); |
Check failure
Code scanning / Checkmarx One
Second Order SQL Injection Critical
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/DBOPS-31
📔 Objective
Adding CSV import/export logic. Export works from SQL server, import works with SQL Server, Postgres, MariaDB, and Sqlite.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes