Skip to content

feat: Allow files in wheels to be installed to directories #3233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Allow files in wheels to be installed to directories #3233

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f61b4cf
Allow files in wheels to be installed to directories
Ahajha Sep 3, 2025
c9f1b27
Allow files or groups of files to be installed to directories
Ahajha Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions python/private/py_wheel.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,9 +505,9 @@ def _py_wheel_impl(ctx):

for target, filename in ctx.attr.data_files.items():
target_files = target[DefaultInfo].files.to_list()
if len(target_files) != 1:
if len(target_files) != 1 and not filename.endswith("/"):
fail(
"Multi-file target listed in data_files %s",
"Multi-file target listed in data_files %s, this is only supported when specifying a folder path (i.e. a path ending in '/')",
filename,
)

Expand All @@ -519,11 +519,15 @@ def _py_wheel_impl(ctx):
filename,
),
)
other_inputs.extend(target_files)
args.add(
"--data_files",
filename + ";" + target_files[0].path,
)

for file in target_files:
final_filename = filename + file.basename if filename.endswith("/") else filename

other_inputs.extend(target_files)
args.add(
"--data_files",
final_filename + ";" + file.path,
)

ctx.actions.run(
mnemonic = "PyWheel",
Expand Down