Decouple Container Instance Health from the doctor. #4811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…doctor implementation.
alexcmms
changed the title
harishxr
reviewed
Nov 18, 2025
Comment on lines
+76
to
+79
| InstanceHealthCheckStatusInitializing InstanceHealthCheckStatus = iota | ||
| InstanceHealthCheckStatusOk | ||
| InstanceHealthCheckStatusImpaired | ||
| ) |
Contributor
There was a problem hiding this comment.
We should probably add back the comments we had for these const in the old ecs-agent/doctor/healthcheckstatus.go file
harishxr
reviewed
Nov 19, 2025
| InstanceHealthCheckTypeContainerRuntime = "ContainerRuntime" | ||
| InstanceHealthCheckTypeAgent = "Agent" | ||
| InstanceHealthCheckTypeEBSDaemon = "EBSDaemon" | ||
| InstanceHealthCheckTypeNvidia = "NvidiaAcceleratedHardware" |
Contributor
There was a problem hiding this comment.
Where is this constant going to be used?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change decouples Container Instance Health from the doctor. The primary changes are:
Implementation details
The instanceStatusMessages chan follows the existing pattern of for container health and metrics in the TCS client. The addition of the chan is optional when instantiating the client in order to maintain backwards compatibility.
Testing
Description for the changelog
Enhancement - Decouple Container Instance Health from the doctor.
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
No
Does this PR include the addition of new environment variables in the README?
No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.