Test CI package update #72
Open
+599
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giulio93
force-pushed
the
test_package_update_rebase
branch
4 times, most recently
from
87a69c0 to
8f3cdf2
Compare
giulio93
force-pushed
the
test_package_update_rebase
branch
from
8f3cdf2 to
4acce61
Compare
giulio93
force-pushed
the
test_package_update_rebase
branch
2 times, most recently
from
726ecbb to
d80dab8
Compare
giulio93
force-pushed
the
test_package_update_rebase
branch
from
d80dab8 to
7442c09
Compare
lucarin91
requested changes
Nov 13, 2025
Comment on lines
+130
to
+166
| build-image: | ||
| desc: "Builds the mock-repo Docker image (requires GITHUB_TOKEN_FILE)" | ||
| deps: [build-deb] | ||
| vars: | ||
| PKG_PATH: "{{.NEW_PACKAGE}}" | ||
| cmds: | ||
| # --- MODIFIED --- | ||
| # Check for both the package and the token file | ||
| - | | ||
| if [ ! -f "{{.GITHUB_TOKEN_FILE}}" ]; then | ||
| echo "Error: GitHub token file not found at {{.GITHUB_TOKEN_FILE}}" | ||
| echo "Please create this file and add your GitHub PAT to it." | ||
| exit 1 | ||
| fi | ||
| - | | ||
| echo "Using package: {{.PKG_PATH}}" | ||
| echo "Using GitHub token from: {{.GITHUB_TOKEN_FILE}}" | ||
| # Enable BuildKit and pass the secret | ||
| DOCKER_BUILDKIT=1 docker build \ | ||
| --secret id=github_token,src={{.GITHUB_TOKEN_FILE}} \ | ||
| --build-arg NEW_PACKAGE_PATH={{.PKG_PATH}} \ | ||
| -t newdeb \ | ||
| -f test.Dockerfile . | ||
| status: | ||
| - '[[ -f "{{.PKG_PATH}}" ]]' | ||
| - '[[ -f "{{.DOCKERFILE_NAME}}" ]]' | ||
| # Re-build if token file changes | ||
| - '[[ -f "{{.GITHUB_TOKEN_FILE}}" ]]' | ||
|
|
||
| test-deb: | ||
| desc: Test the debian package locally | ||
| deps: | ||
| - build-deb | ||
| cmds: | ||
| - docker build --no-cache -t mock-apt-repo -f test.Dockerfile . | ||
| - docker run --rm -it --privileged -v /sys/fs/cgroup:/sys/fs/cgroup:ro --name apt-test-update mock-apt-repo |
Comment on lines
+15
to
+17
| NEW_PACKAGE: | ||
| sh: ls -1 ./build/arduino-app-cli_*.deb 2>/dev/null | head -n 1 | ||
| GITHUB_TOKEN_FILE: ./github_token.txt |
| - go build ./cmd/arduino-app-cli # needed for e2e tests | ||
| - task: generate | ||
| - go test ./internal/... ./cmd/... -v -race {{ .CLI_ARGS }} | ||
| - go test $(go list ./internal/... ./cmd/... | grep -v internal/e2e/updatetest) -v -race {{ .CLI_ARGS }} # exclude deb package update tests |
Contributor
There was a problem hiding this comment.
I would propose this instead
test:internal:
cmds:
- go build ./cmd/arduino-app-cli
- task: generate
- go test $(go list ./internal/... ./cmd/... | grep -v internal/e2e/updatetest) -v -race {{ .CLI_ARGS }}
test:update:
cmds:
- go test --timeout 30m -v ./internal/e2e/updatetest
Contributor
There was a problem hiding this comment.
I think you can remove this file
Contributor
There was a problem hiding this comment.
can you rename the file to update_test.go
lucarin91
reviewed
Nov 13, 2025
| @@ -0,0 +1,31 @@ | |||
| name: Build & Update with Arduino CLI | |||
Contributor
There was a problem hiding this comment.
Suggested change
| name: Build & Update with Arduino CLI | |
| name: test the system update flow |
| env: | ||
| GH_TOKEN: ${{ secrets.ARDUINOBOT_TOKEN }} | ||
| run: | | ||
| go test -count=1 --timeout 30m -v ./internal/e2e/updatetest -- --arch amd64 |
Contributor
There was a problem hiding this comment.
Suggested change
| go test -count=1 --timeout 30m -v ./internal/e2e/updatetest -- --arch amd64 | |
| go tool task test:update |
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| var arch = flag.String("arch", "amd64", "target architecture") |
Contributor
There was a problem hiding this comment.
Isn't this just
Suggested change
| var arch = flag.String("arch", "amd64", "target architecture") | |
| var arch = runtime.GOARCH |
I would expect that you want to install/build the artifact with the same architecture of the current machine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR implement point 3 and 4 of this issue https://github.com/arduino/private-tooling-team/issues/349
Here we implement a Github CI to test the update package in two way: