refactor: Extract API storage client creation from the Apify storage code #663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
t-tooling
Contributor
Author
|
Refactoring refactoring to the discussion in: |
Pijukatel
commented
Nov 5, 2025
Pijukatel
commented
Nov 5, 2025
github-actions
bot
added
the
tested
Without additional inheritance in individual storage clients.
vdusek
force-pushed
the
refactor-open-storage-methods
branch
from
64ccb91 to
7c40de0
Compare
Pijukatel
commented
Nov 12, 2025
Contributor
Author
Pijukatel
left a comment
Pijukatel
left a comment
There was a problem hiding this comment.
I am fine with this approach as well. Just some small comments
|
|
||
| async def create_api_client( | ||
| *, | ||
| storage_type: Literal['key_value_store', 'request_queue', 'dataset'], |
Contributor
Author
There was a problem hiding this comment.
Is there any benefit in keeping this virtual mapping between class and literal?
Why not use the class directly?
Contributor
There was a problem hiding this comment.
import hell (circular imports) - this is a better approach, trust me, I've been there 😄
Pijukatel
commented
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
openmethod toApiClientFactoryopenmethods of Apify storages.