Skip to content

Emit final snapshot before run finished event #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Emit final snapshot before run finished event #642

wants to merge 4 commits into from

Conversation

@contextablemark
Copy link
Collaborator

@contextablemark contextablemark commented Nov 5, 2025

Addresses #640 by following the pattern of Langgraph, Vercel and Crew AI integrations of implementing a MESSAGES_SNAPSHOT at the end of each run.

Summary

  • emit the final messages snapshot before propagating the RUN_FINISHED event so listeners receive the complete transcript beforehand
  • cover the ordering change in the default text message apply test to ensure the snapshot precedes the run finished notification

Testing

  • pnpm --filter @ag-ui/client test -- --runTestsByPath src/apply/tests/default.text-message.test.ts

@contextablemark contextablemark changed the title Contextablemark/feature/issue640 Emit final snapshot before run finished event Nov 5, 2025
@rrazvd rrazvd mentioned this pull request Nov 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mme mme Awaiting requested review from mme mme is a code owner

@ranst91 ranst91 Awaiting requested review from ranst91 ranst91 is a code owner

@ataibarkai ataibarkai Awaiting requested review from ataibarkai ataibarkai is a code owner

@maxkorp maxkorp Awaiting requested review from maxkorp maxkorp is a code owner

@tylerslaton tylerslaton Awaiting requested review from tylerslaton tylerslaton is a code owner

@NathanTarbert NathanTarbert Awaiting requested review from NathanTarbert NathanTarbert is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@contextablemark